Giter VIP home page Giter VIP logo

Comments (6)

axxel avatar axxel commented on May 27, 2024 1

No, they are not. Please read the ArwDecoder once more :)

I see. Makes sense. As I said: I did not investigate further. So my worries were unfounded.

from rawspeed.

LebedevRI avatar LebedevRI commented on May 27, 2024

the cameras.xml says that it should be:

	<Camera make="SONY" model="DSLR-A850">
		<ID make="Sony" model="DSLR-A850">Sony DSLR-A850</ID>
		<CFA width="2" height="2">
			<Color x="1" y="1">BLUE</Color>
			<Color x="1" y="0">GREEN</Color>
			<Color x="0" y="1">GREEN</Color>
			<Color x="0" y="0">RED</Color>
		</CFA>
		<Crop x="0" y="0" width="6080" height="4048"/>
		<Sensor black="500" white="15000"/>
	</Camera>
	<Camera make="SONY" model="DSLR-A900">
		<ID make="Sony" model="DSLR-A900">Sony DSLR-A900</ID>
		<CFA width="2" height="2">
			<Color x="0" y="0">RED</Color>
			<Color x="1" y="0">GREEN</Color>
			<Color x="0" y="1">GREEN</Color>
			<Color x="1" y="1">BLUE</Color>
		</CFA>
		<Crop x="0" y="0" width="6080" height="4048"/>
		<Sensor black="520" white="16383"/>
	</Camera>

from rawspeed.

LebedevRI avatar LebedevRI commented on May 27, 2024

Exif says that they are 12-bit, so the old black/white levels look more correct
gonna check in dt next

from rawspeed.

LebedevRI avatar LebedevRI commented on May 27, 2024

@axxel for RAW_SONY_A850.ARW and RAW_SONY_A900.ARW from rpu, the

-blackLevel: 125
-whitePoint: 3750

and

-blackLevel: 130
-whitePoint: 4095

are the right ones.
with the values you pasted, images look completely crippled.

from rawspeed.

axxel avatar axxel commented on May 27, 2024

OK, so the numbers in the xml are wrong. The code I pushed did not change the behavior. So the old numbers are still used, wherever they are actually from (did not investigate).

from rawspeed.

LebedevRI avatar LebedevRI commented on May 27, 2024

OK, so the numbers in the xml are wrong.

No, they are not. Please read the ArwDecoder once more :)
Especially grep for mShiftDownScale.

The metadata in XML (for arw raws in general it seems) is specified for 14-bit raws.
These raws are 12-bit. So for them the metadata is computed by simply >> 2.

EDIT: s/xmp/XML/

from rawspeed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.