Unable to rebuild the plugin using CLion's Platform SDK about glsl4idea HOT 11 CLOSED

TL;DR: What was deprecated on IDEA 14.1 has been removed in CLion - this means that the next IntelliJ IDEA point version will break the plugin.

I've fixed the compilation errors here: https://github.com/agatti/glsl4idea/tree/clion-1.0 - however I wasn't able to make CLion pick the plugin up.

Still, I've tried to build the plugin using the IntelliJ IDEA Ultimate 14.1 platform SDK and all but one errors I get in CLion are related to deprecated functionalities in the IDEA SDK. Moreover, GLSLStructureViewFactory doesn't compile on IDEA either, you may want to see whether my modifications make it work there.

from glsl4idea.

I have manually merged your changes and removed remaining deprecated parts, can you please try compiling it now?

from glsl4idea.

After I replace all calls to FileTemplateManager.getInstance() with FileTemplateManager.getDefaultInstance() it builds without warnings or errors using the CLion SDK. It still doesn't load for some other reason though, as it seems like it's not activated or something. As you can see in the attached image, it gets disabled by CLion but providing no meaningful error message in the console when launching it:

I'll try packaging the plugin into a JAR myself and see if things change if installed that way.

from glsl4idea.

Same thing, I get this in the log:

2015-04-19 21:57:12,189 [ 1268] INFO - llij.ide.plugins.PluginManager - Disabled plugins: CSS Support, GLSL Support (1.2), HTML Tools (2.0), JavaScript Intention Power Pack (0.9.4), JavaScript Support (1.0), REST Client

Maybe there's a way to run CLion in "verbose" mode, I'll look into this.

from glsl4idea.

Intellij 14.1 doesn't even have a getDefaultInstance() method, this is very strange. It might be caused by some antique code I haven't yet visited to clean up or by doing something wrong, which is hard to tell, since the documentation is so scarce.

from glsl4idea.

getInstance() still works on CLion (or rather, it should), so that's not much of a concern. However, I've tried a few things here and I wasn't able to figure out yet which logger must be put in debug mode to see why a plugin gets disabled. I suspect it's something with the XML file, though.

from glsl4idea.

I was able to let CLion enable (and run) the plugin with this: https://github.com/agatti/glsl4idea/commit/d659ec4c905070d2cf5d92a418ada1136d541b83 - please check if that works in IntelliJ too...

from glsl4idea.

Oh, and by the way, I just checked with IntelliJ 14.1.1 Ultimate - FileTemplateManager.getDefaultInstance() is indeed available.

from glsl4idea.

I have CE, that might be the problem, or something is wrong with my setup. Anyway, those changes to plugin.xml didn't break anything, I have pushed them, you can try compiling it now, should be the same as your fork. Btw. how did you manage to find the solution?

from glsl4idea.

Yep, it works, thanks a lot! It still misses some GLES stuff but I plan to add that myself and submit a PR later on, at least now I can get it to work somehow :)

For how I fixed that, I've checked the XML file of another plugin I had installed in CLion for which I could get the source (namely https://github.com/nicoulaj/idea-markdown) - once I compared the two XML files it was fairly evident where the problem was (plugin root tag version, dependencies, and minimum build number for IntelliJ).

So I guess that if the reporter for #22 says it works there as well this can be closed, what do you think?

from glsl4idea.

I was hoping that you found some reference for plugin.xml (like I was looking for for some time), but this is fine as well, it doesn't look like it broke something. Thanks for your help. There is a lot of stuff still missing, I wanted to add it, but this plugin is a large beast so I wanted to understand it first. But if you manage it somehow, PRs are welcome.

This issue is by its title about building and that seems to work, so I'll close it.
(closed by 974ea93)

from glsl4idea.