Giter VIP home page Giter VIP logo

Comments (8)

lifflander avatar lifflander commented on June 28, 2024 1

@cz4rs @pierrepebay

Here is a pointer to the incorrect JSON: https://github.com/DARMA-tasking/vt-tv/blob/master/tests/unit/lb_test_data/data.0.json

An entity with "home": 0, "id": 0, exists in the communications, but is not present in the tasks. This data was generated using lb_iter on 4 ranks, that should reproduce the bug. I think this bug is easy to reproduce (probably with multiple benchmarks).

from vt.

lifflander avatar lifflander commented on June 28, 2024 1

I believe that this code:

void ActiveMessenger::startup() {
bare_handler_dummy_elm_id_for_lb_data_ =
elm::ElmIDBits::createBareHandler(this_node_);
#if vt_check_enabled(lblite)
// Hook to collect LB data about objgroups
thePhase()->registerHookCollective(phase::PhaseHook::DataCollection, [this]{
theNodeLBData()->addNodeLBData(
bare_handler_dummy_elm_id_for_lb_data_, &bare_handler_lb_data_, nullptr
);
});
#endif

Is creating that entry, but it's not being output as a task because maybe it's zero work?

from vt.

pierrepebay avatar pierrepebay commented on June 28, 2024 1

@cz4rs additionally if this can help, when I encountered the bug I went through the data (the one @lifflander pointed to) for the 4 ranks by hand, and sketched this out:
image
It shows what is contained in the communications section of the json for each of the 4 ranks, and whether the endpoints of each communication are present in the tasks field for that rank or not (circled in green or red). It shows how object 0 doesn't exist in any of the ranks.

from vt.

lifflander avatar lifflander commented on June 28, 2024

@pierrepebay Please post JSON that is incorrect.

from vt.

lifflander avatar lifflander commented on June 28, 2024

@lifflander I will write unit test for this that reproduces.

from vt.

cz4rs avatar cz4rs commented on June 28, 2024

Output from lb_iter with downsized problem (running on two ranks), bare handlers are marked explicitly:
data.1.json
data.0.json

from vt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.