Giter VIP home page Giter VIP logo

Comments (5)

alanjoyce avatar alanjoyce commented on June 27, 2024

Is this because we're not using scss and/or it isn't necessary anymore? If so, should we just migrate the styles we need into dart-style.css and get rid of our dependency on scss?

from www.dartlang.org.

adam-singer avatar adam-singer commented on June 27, 2024

I think so. Not sure what exists in those sass files that might conflict with the dart-style.css

from www.dartlang.org.

alanjoyce avatar alanjoyce commented on June 27, 2024

Ok, I think the best approach here is to standardize wherever we can to Bootstrap elements and styles. We can then modify those styles as needed in dart-style.css, but hopefully we won't need to do a ton of this.

The old site had a bunch of fiddly specific styles for things like the thumbnails on /slides/. We replaced those standard Bootstrap thumbnails and should do the same for other similar cases, such as the colored boxes on /docs/tutorials/get-started/.

Yes, this will make some pages more boring/standardized, but it'll result in a much more maintainable set of styles and templates for the site.

from www.dartlang.org.

adam-singer avatar adam-singer commented on June 27, 2024

At some point we should also delete the scss directory

from www.dartlang.org.

alanjoyce avatar alanjoyce commented on June 27, 2024

Yep, filed #184

from www.dartlang.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.