relative() returns incorrect result about path HOT 7 CLOSED

https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/commands/create.dart#L131

from path.

This looks correct to me. It satisfies the invariant that p.join(from, p.relative(path, from: from)) refers to the same path as path.

import 'package:path/path.dart' as p;

void main() {
  var from = "/var/folders/00/0w978000h01000cxqpysvccm003j4x/T/flutter_toolsZUIVMq";
  var path = "/Users/devoncarew/projects/flutter/flutter/packages";

  print(p.normalize(from, p.join(p.relative(path, from: from))));
  // => /Users/devoncarew/projects/flutter/flutter/packages
}

Keep in mind that the from argument takes the place of the current directory. So if flutter_toolsZUIVMq is a file and you want a relative path that is valid within that file, from should be /var/folders/00/0w978000h01000cxqpysvccm003j4x/T.

from path.

flutter_toolsZUIVMq is a directory - we're creating a pubspec file in there and trying to write a relative path from there to the flutter package. (flutter_toolsZUIVMq/pubspec.yaml)

from path.

In that case, the path you listed should work. I count six ..s, which matches the six path segments in from.

from path.

But from flutter_toolsZUIVMq, it's only 5 segments up.

What's odd is that this test works on linux. And it does look like the relative path being created in the pubspec is bad.

from path.

But from flutter_toolsZUIVMq, it's only 5 segments up.

Not if it's a directory and you're resolving a path inside it. You still have to .. up through flutter_toolsZUIVMq.

What's odd is that this test works on linux. And it does look like the relative path being created in the pubspec is bad.

I suspect the real issue here is OS X's symlinking of the /tmp directory. Relative paths that move up out of symlinked directories are unreliable; they can be resolved differently depending on what the resolving entity thinks the current working directory's path is.

from path.

Ah, something to look into. I'll see if canonicalizing the paths helps.

from path.