[analysis_server] Non-const constructors aren't suggested in a const context about sdk HOT 2 OPEN

I'm not saying that you're wrong, but we also get issues requesting that code completion not suggest non-const constructors in a const context.

I think the problem here is that sometimes const means that const is a requirement and sometimes, especially in Flutter code, it means const is preferred when it's possible but can go away if necessary. I'm not sure whether there's a good heuristic we can use to know which is which, but without one we're bound to do the wrong thing part of the time.

from sdk.

Hmm...good point. I suppose it doesn't make too much sense to get recommended non-const constructors for situations like parameter default values.

On the other hand, my initial feeling is that it's also a bit surprising for a possibility to not show up even in those cases. If it does show up and I try the completion, I at least know it exists and why I can't use it there from the resulting diagnostic. If it doesn't show up as a suggestion, I might think the type is removed or not available in the current library scope.

from sdk.