Comments (3)
Leave respQueue
channel open is because:
// Send pushes response message entry to respQueue.
// Returns false if session is closed or ctx is done.
func (s *session) Send(ctx Context) (ok bool) {
select {
case <-ctx.Done():
return false
case <-s.closed:
return false
case s.respQueue <- ctx:
return true
}
}
In Send
method, it will try to push ctx to respQueue
channel, it can cause a panic if the channel is closed.
And it's ok to keep a channel open.
from easytcp.
thanks for your reply. And i have found the relative topic on stackoverflow.
I'm consider it might lead to the memory leak.
from easytcp.
I don't think there will be memory leak, have tested already.
All goroutines will exit once the session's closed or the server's stopped.
from easytcp.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from easytcp.