Giter VIP home page Giter VIP logo

Comments (6)

jboillot avatar jboillot commented on May 31, 2024 2

Hello!

The reason for accessing the OS keychain before the first login is that we didn't want users to go through the whole login process, and at the end get an error, which would force them to start over again from the beginning.

However, it should be possible to postpone the keychain access, save the local key encrypted using the master password in the DB, and display a warning instead of an error if the keychain is unreachable.

What are your opinions?

from dashlane-cli.

Mikescops avatar Mikescops commented on May 31, 2024 1

Oh ok, I'll have a deeper look then, thanks!

from dashlane-cli.

Mikescops avatar Mikescops commented on May 31, 2024

Hello,
At which step do you stop? There are multiple steps in the authentication process and the local password (stored in the keychain) is required quite early in the process to protect some secrets.

from dashlane-cli.

BenjaminOddou avatar BenjaminOddou commented on May 31, 2024

Hello @Mikescops,

I stopped after entering the mail. In the screenshot the account is test which is not a valid email but it still creates a keychain password in that case.

? Please enter your email address: test
DashlaneApiError: Internal Error
    at requestApi (/snapshot/dashlane-cli-master/dist/requestApi.js:79:23)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async registerDevice (/snapshot/dashlane-cli-master/dist/middleware/registerDevice.js:15:30)
    at async getSecretsWithoutDB (/snapshot/dashlane-cli-master/dist/crypto/keychainManager.js:81:50)
    at async connectAndPrepare (/snapshot/dashlane-cli-master/dist/database/connectAndPrepare.js:24:21)
    at async Command.<anonymous> (/snapshot/dashlane-cli-master/dist/index.js:34:29)
    at async Command.parseAsync (/snapshot/dashlane-cli-master/node_modules/commander/lib/command.js:917:5) {
  code: 'internal_error',
  type: 'server_error'
}

from dashlane-cli.

Mikescops avatar Mikescops commented on May 31, 2024

Looks good to me!

from dashlane-cli.

jboillot avatar jboillot commented on May 31, 2024

This issue should be fixed in next release.

from dashlane-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.