Giter VIP home page Giter VIP logo

Comments (3)

GenevieveBuckley avatar GenevieveBuckley commented on August 17, 2024

I should add, it's not a fatal error.

The conclusion I'd drawn from that plot was "This is consistent with what we might expect, since the healthy lung is more well developed than the lung from the hernia model." which is still supported by the correct interpretation of the plot - that there is a longer end-to-end distance for most blood vessels in the healthy lung. This makes sense, as the lung with the hernia is squashed into a smaller volume than the healthy one.

from dask-blog.

GenevieveBuckley avatar GenevieveBuckley commented on August 17, 2024

It would be better if the violin plot show was one for branch-distance (the total length of the branch).

Alternatively, the violin plot can stay the same (showing euclidean-distance), and the text updated to reflect the fact this is really measuring the end-to-end distance between branch start and end points, as if you'd pulled a string taught between them. That makes slightly less sense to show, when you could otherwise just show the branch distance, but it doesn't require re-analysing the data to generate a new plot.

Related: jni/skan#197

from dask-blog.

GenevieveBuckley avatar GenevieveBuckley commented on August 17, 2024

Alternatively, the violin plot can stay the same (showing euclidean-distance), and the text updated to reflect the fact this is really measuring the end-to-end distance between branch start and end points, as if you'd pulled a string taught between them. That makes slightly less sense to show, when you could otherwise just show the branch distance, but it doesn't require re-analysing the data to generate a new plot.

Update, we're taking this approach. It's the easier way out. I had a quick look at my analysis repo here and it doesn't seem super quick to re-run and generate a new plot - I'd have to find the original data and make some changes to the notebook first.

from dask-blog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.