Comments (4)
botandrose
commented on July 21, 2024
1
@bsuchodolski I think it should be removed as the default option. Since we're explicitly passing truncate_tables an explicit list of tables to remove, it truncating additional tables seems like a bug.
from database_cleaner-active_record.
botandrose
commented on July 21, 2024
@bsuchodolski Yes, I'm inclined to agree that its a bug if the truncate_tables function is truncating additional tables that aren't in the table_names argument. Can you prepare a PR for this?
from database_cleaner-active_record.
bsuchodolski
commented on July 21, 2024
@botandrose I'll try to find some time this week or in weekend and let you know :) Do you think it should be an opt-in solution where you pass additional param to use RESTRICT or the CASCADE option should be removed as default option (as this is causing the bug)?
from database_cleaner-active_record.
bsuchodolski
commented on July 21, 2024
Hey @botandrose PR(#58) is ready for some time now, is there anyone else besides you I can ask for code review?
from database_cleaner-active_record.
Related Issues (20)
- Transaction strategy configured with symbol(connection name) does not work HOT 1
- CI is not being executed against Rails 7.1 stable (and probably 7.1 compatibility is broken on main)
- Strategy :transaction doesn't work with click_button HOT 12
- Truncation failure with CockroachDB HOT 2
- PostgreSQL truncation is broken on 2.0.1 HOT 7
- Where's the changelog? HOT 3
- Delete cascade HOT 1
- README.md -> invalid ruby syntax
- Cleaning fails with PG::UndefinedColumn: ERROR: column "increment_by" does not exist HOT 2
- Always exclude `pg_*` tables in PostgreSQL truncation
- Broken with Rails 7.1 HOT 2
- edge rails (future 7.1) no longer has ActiveRecord::SchemaMigration.table_name HOT 4
- v2.0.1 is throwing deprecation warning for using #tables instead of #data_sources HOT 3
- Stale connection in `DatabaseCleaner::ActiveRecord::Truncation#connection` HOT 1
- truncation and deletion doesn't call after_commit
- Issue with the upcoming Factory Bot Rails due to lacking of lazy load hooks HOT 4
- Unable to load application: LoadError: cannot load such file -- database_cleaner/active_record
- [FIX] Make more meaningful methods name
- Accidental replacement of main DB model connections in multi-database env
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from database_cleaner-active_record.