Affiliation identifiers are not normalized consistently when reading from DataCite XML about bolognese HOT 2 CLOSED

The goal here should be to never discard regardless if url or not.
I think the proposal of using something like how name_identifiers works makes sense to me.

from bolognese.

I was able to reproduce this bug locally with following steps.

This works

1. From this fixture file remove schemeURI attribute and keep affiliationIdentifier with URL

   bolognese/spec/fixtures/datacite-example-ROR-nameIdentifiers.xml

   Line 9 in b0a7df3

   <affiliation schemeURI="https://ror.org" affiliationIdentifier="https://ror.org/05bp8ka05" affiliationIdentifierScheme="ROR"> Metadata Game Changers </affiliation>

After processing this XML file at bolognese/spec/author_utils_spec.rb:163. We will see that creators with affiliation will have affiliationIdentifier in the response after processing this metadata.

(byebug) subject.creators[0]
{"nameType"=>"Personal", "name"=>"Robinson, Erin", "givenName"=>"Erin", "familyName"=>"Robinson", "nameIdentifiers"=>[{"schemeUri"=>"https://orcid.org", "nameIdentifierScheme"=>"ORCID"}], "affiliation"=>[{"name"=>"Metadata Game Changers", "affiliationIdentifier"=>"https://ror.org/05bp8ka05", "affiliationIdentifierScheme"=>"ROR"}]}

This won't work

2. From this fixture file remove schemeURI attribute and keep affiliationIdentifier without URL like below,

<creator>
    <creatorName nameType="Personal">Erin Robinson</creatorName>
    <nameIdentifier schemeURI="https://orcid.org/" nameIdentifierScheme="ORCID"> https://orcid.org/0000-0001-9998-0114 </nameIdentifier>
    <affiliation affiliationIdentifier="05bp8ka05" affiliationIdentifierScheme="ROR"> Metadata Game Changers </affiliation>
</creator>

Now in the test file add byebug bolognese/spec/author_utils_spec.rb:163 and check subject after processing the schema. we will see affiliation attribute in the response does not have affiliationIdentifier.

(byebug) subject.creators[0]
{"nameType"=>"Personal", "name"=>"Robinson, Erin", "givenName"=>"Erin", "familyName"=>"Robinson", "nameIdentifiers"=>[{"schemeUri"=>"https://orcid.org", "nameIdentifierScheme"=>"ORCID"}], "affiliation"=>[{"name"=>"Metadata Game Changers", "affiliationIdentifierScheme"=>"ROR"}]}

from bolognese.