Editor navigation/usage issues about datafusion-tui HOT 3 CLOSED

Hi @matthewmturner ,

thanks for your quick reply! I indeed did not test the latest version of the code - you are really quick integrating new features. :)
I prepared a PR with some unit tests in the hope that they will help. I think, I will wait a little bit with a PR for handling non-ascii characters because it looks like that you are currently reorganizing the code quite a bit and a probability for a conflict is quite high at the moment. And maybe you will fix everything by yourself - quick as you are. :D

And no need to re-prioritize your work - I'm sure you know better what is more important! I just was curious how the new UI for Datafusion will look like and wanted to help a little bit.

Regarding unit tests which you mentioned: if you create a short document with things which you would like to test first, I could try to take over some of the tasks.

Best

from datafusion-tui.

Hi @seryj! Thanks so much for the report.

Yes, i definitely agree the application still crashes more than it should. I am very glad to have someone else using it so i can find out more when these issues happen :) thank you again for raising.

Can you confirm you are on latest master? I am making updates frequently - often related to crashes (in particular driven from editor). For example, i fixed the issue on moving cursor panics when no text is present and correctly typing characters inside a line.

I am definitely very happy to accept PRs, in particular with unit tests. Adding tests are currently on my to-do list but i havent had chance to work on them yet.

Let me know if any other issues are of interest to you - im happy to reprioritize my efforts where others see value. my next big focus will likely be on #39 which i think can add a lot of value.

thanks again.

from datafusion-tui.

Thank you @seryj - very helpful!

Yes - there is definitely a bit of reorganization going on. The next piece is likely #47 which will make it easier to add new tabs and allow the project to be more extensible. After that, I'm hoping the core / editor will be at least somewhat stable.

The help is definitely appreciated - i didnt think anyone was really using yet 😅

To the extent you continue using it and can find / report bugs or features i will definitely prioritize getting those fixed / added. Thats basically how im driving my own prioritization list (im trying to make it my interactive data analysis tool of choice).

I can also definitely work on documenting some test ideas. getting more done there would be super valuable.

from datafusion-tui.