Key duplication in configMaps causing errors on some deployment tools about pulsar-helm-chart HOT 6 CLOSED

@nuriel77 - thank you for this detailed issue. It should definitely be cleaned up. I should be able to fix this and deploy an updated chart early next week.

from pulsar-helm-chart.

@michaeljmarshall Hi! Thanks.

Do I understand correctly that these might be the types of values the workaround was trying to fix: https://github.com/datastax/pulsar-helm-chart/pull/107/files#diff-3be28e7b230396d61d2bc7bd74e5e00070fbfa2c507caa36269a18bfe502df52L37
(as I've notice those would result in getting wrapped by single quotes when using toYaml)

If that is the case, did you consider trying the following approach that might just work for all cases:

---
apiVersion: v1
kind: ConfigMap
metadata:
  name: "cm-pulsar-broker"
  labels:
    app: pulsar
data:
{{- range $key, $val := $.Values.broker.configData }}
  {{ $key }}: {{ $val | replace "\"" "" | trim | quote }}
{{- end }}

Tested with the following values:

broker:
  configData:
    managedLedgerDefaultWriteQuorum: "2"
    zookeeperServers: "cm-pulsar-zookeeper-from-values-file:2181"
    PULSAR_MEM: "\"-Xms312m -Xmx312m -XX:MaxDirectMemorySize=200m -XX:+ExitOnOutOfMemoryError\""
    PULSAR_GC: "-XX:+UseG1GC"
    PULSAR_TEST: some test values

Result:

apiVersion: v1
kind: ConfigMap
metadata:
  name: "cm-pulsar-broker"
  labels:
    app: pulsar
data:
  PULSAR_GC: "-XX:+UseG1GC"
  PULSAR_MEM: "-Xms312m -Xmx312m -XX:MaxDirectMemorySize=200m -XX:+ExitOnOutOfMemoryError"
  PULSAR_TEST: "some test values"
  managedLedgerDefaultWriteQuorum: "2"
  zookeeperServers: "cm-pulsar-zookeeper-from-values-file:2181"

from pulsar-helm-chart.

Are you interested in creating a PR with this fix?

Sure. I will be able to do it tomorrow morning (around European timezone) 👍

from pulsar-helm-chart.

@nuriel77 - #107 resolves this issue. It is technically a breaking change for users that have old values, so we are not going to merge/release this fix until 3.0.0. We plan to release 3.0.0 in the first half of January.

from pulsar-helm-chart.

Do I understand correctly that these might be the types of values the workaround was trying to fix: https://github.com/datastax/pulsar-helm-chart/pull/107/files#diff-3be28e7b230396d61d2bc7bd74e5e00070fbfa2c507caa36269a18bfe502df52L37
(as I've notice those would result in getting wrapped by single quotes when using toYaml)

@nuriel77 - yes, those are exactly the the values the fix was working around. This looks like a good solution to prevent breaking changes. Are you interested in creating a PR with this fix? If not, I should be able to contribute this fix tomorrow.

from pulsar-helm-chart.

This was fixed by #110. Thanks for your contribution @nuriel77. I'll run a 2.0.11 release later today that will include this fix.

from pulsar-helm-chart.