Giter VIP home page Giter VIP logo

Comments (5)

adamkaplan avatar adamkaplan commented on May 18, 2024

That will work, but clearly it is not ideal from a syntactic or logical perspective. Perhaps the two keys should be optional if 'enforce' is false?

from trustkit.

nabla-c0d3 avatar nabla-c0d3 commented on May 18, 2024

Yeah, right now there is no clean way to do what you're trying to do. I am thinking about adding the option to not pin a domain (nor specify pins) but still get the reports.

from trustkit.

omerlh avatar omerlh commented on May 18, 2024

I am not sure in such case I would be interested in the reports. Anyway, if that helps, I might be able to create a PR that will enforce those keys if pinning is disabled.

from trustkit.

nabla-c0d3 avatar nabla-c0d3 commented on May 18, 2024

What prevents you from listing the domains you want to pin (instead of the other way around)?

from trustkit.

omerlh avatar omerlh commented on May 18, 2024

We have one endpoint in our domain that is served by Cloudflare, and all other domains (>20) are served from our servers. So it is easier (especially looking forward) to disable pinning for that domain, and not enabling it for all of the other domains.

from trustkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.