monitoring.coreos.com/servicemonitor_v1.json - missing support for the enableHttp2 field about crds-catalog HOT 6 CLOSED

Hi @eyarz
Thanks for looking at it. I identified the same thing, the schema is out of date.
I already have the up-to-date custom resource deployed in my cluster and I tried using the crd-extractor tool to generate a new schema from it but the result I got didn't include anything extra for the new http2 option.
If I get a chance a bit later I will try again in case I was doing something wrong

from crds-catalog.

Hi @martinrw , it is worth checking to see if there is a new version of the schema, but in the meantime you can use the --permissive-schema flag to allow additional properties.

from crds-catalog.

Hey @hadar-co
Thanks for the quick reply and your suggestion.
I am using the latest schemas from this repo.

We are using the kubeconform command and not datree so that's not an option unfortuantely.
This is my first time really looking at this but I think the workaround for now might be to change:
"additionalProperties": false
to
"additionalProperties": true
in my local copy of monitoring.coreos.com/servicemonitor_v1.json for now.
or maybe even delete this line altogether.
It's Friday afternoon now so I'll have a play with it next week

from crds-catalog.

Well, kubeconform allows additional properties by default, are you setting the -strict flag by mistake?

If you want to send the schema I can take a closer look:)

from crds-catalog.

Thanks for the offer to look. We aren't using the strict flag but I think this setting within the schemas:
"additionalProperties": false
is effectively doing the same thing as strict.
I have adjusted my copy of the schemas to have:
"additionalProperties": true
everywhere and now it seems OK.

The ideal solution would be for the schemas to be updated so I think this ticket is still valid, but at least I can continue for now

from crds-catalog.

@martinrw I think I found the root cause for this issue.
The last update to the schema in this repo for servicemonitor_v1 was on Jun 2022.

enableHttp2 was added to the original schema (on the helm-charts repo) 20 days ago:

therefore, updating the schema in this repo will solve your issue :)

from crds-catalog.