DashboardPanelShortcuts error with external links about processwire-dashboard HOT 13 CLOSED

Yeah, that makes sense — if it's a string, the first condition is false, so it will evaluate the second condition. If it was completely empty, it wouldn't. Your isset solution is the way to go here...

from processwire-dashboard.

Mmh. Not sure. The if statement would just skip the second part if the first part is true.

Can you post how you're setting up the panel itself, what you're passing into the 'shortcuts' option?

from processwire-dashboard.

Sure :)

Heres my code:

$allshortcuts[] = "";
$allshortcuts['Plan erstellen'] = [$this->config->urls->admin.'page/add/?parent_id=1024&template_id=47', 'calendar',     'Einen neuen Plan erstellen.'];
$allshortcuts['News eintragen'] = [$this->config->urls->admin.'page/add/?parent_id=1023&template_id=45', 'newspaper-o', 'Hier kann ein neuer News Eintrag erstellt werden.'];
$allshortcuts['User syncronisieren'] = [$this->config->urls->admin . 'setup/syncuser/', 'refresh', 'User akutalisieren.'];
$allshortcuts['Updates'] = [$this->config->urls->admin . 'setup/upgrades/', 'download', 'Systemupdates suchen und installieren.'];
$allshortcuts['Einstellungen'] = [$this->config->urls->admin . 'page/edit/?id=' . $this->pages->get("/verwaltung/einstellungen/")->id, 'cogs', 'Hier können die Einstellungen geändert werden.'];
$allshortcuts['Alle Seiten'] = ['/ugs/page/', 'files-o', 'Alle vorhandenen Seiten anzeigen.'];

$panels->add([
    'panel' => 'shortcuts',
    'title' => 'Menü',
    'data' => [
        'shortcuts' => $allshortcuts,
        'display' => 'list',
        'fallbackIcon' => 'star-o',
        'checkAccess' => true
    ]
]);

from processwire-dashboard.

The if statement would just skip the second part if the first part is true.

Only if AND is used but no OR, I guess, so
if (!$page || !isset($page->url)) {
should be needed perhaps?

from processwire-dashboard.

BTW, I get the same PHP Notice, so it an issue. I modifed the code as I showed above, it work for me with isset().
https://stackoverflow.com/questions/8138269/multiple-boolean-conditions-operator-precedence
"&& depends of the evaluation of the right expression when left one is true, || doesn't."

from processwire-dashboard.

$page is not an object in this case, so it does exist but doesn't allow property access. @szabeszg's fix should work. I'll try and plug the example config into my test setup to see why $page is not an object in the first place.

from processwire-dashboard.

I don't think this is about faulty boolean logic. If $page is empty, the first condition !$page is already true so it won't evaluate the second condition since true || [anything] will always be true.

from processwire-dashboard.

If $page is empty, the first condition !$page is already true so it won't evaluate the second condition since true || [anything] will always be true.

Apparently it does evaluate the second one...

from processwire-dashboard.

Looks like it fails when $page is a string like: '/admin/page/edit/?id=1'

from processwire-dashboard.

Just for reference here is the line in question:

Why would a string find it's way to that line? While isset() would work wouldn't it be better to ensure that $page is a Page object at the very top?

from processwire-dashboard.

eg this (but I don't know how your module works exactly and what syntax you expect...):

if(is_string($page)) $page = $this->wire->pages->get($page);

from processwire-dashboard.

The string just means it's already a URL. So yeah, I should go with an additional is_object or is_a and then isset. Better safe than sorry.

from processwire-dashboard.

Fixed in 1.5.2, thanks everybody for reporting and helping troubleshoot!

from processwire-dashboard.