Giter VIP home page Giter VIP logo

Comments (3)

dvdzkwsk avatar dvdzkwsk commented on April 28, 2024

Ah, I see how this is confusing (and it's definitely unintentional). I'll have to look into the best way to patch this, but the issue is that bindInput is still referring to the internal setProperty instead of the one you supplied. See: https://github.com/davezuko/react-reformed/blob/master/src/reformed.js#L34-L47.

You would likely see the correct behavior if you supplied onChange and value directly to the input. I'll take a look at the internals a bit today to see if there's an easy fix.

from react-reformed.

dvdzkwsk avatar dvdzkwsk commented on April 28, 2024

Fixed with #21. It's not the most ideal fix, since it re-creates two functions on each render, but it's the only reliable solution I could come up with. It's technically a breaking change because we can no longer provide bindInput and bindToChangeEvent to the middleware function.

You should be able to pull v2.0.0 and see it working. I've put together an example here: https://codesandbox.io/s/p319vx87wm.

from react-reformed.

tgoorden avatar tgoorden commented on April 28, 2024

Oh wow, thank you. I though I was going crazy there for a second ;)

Thank you for this fix, it seems to work as expected!

from react-reformed.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.