Add capistrano-pending Gem into deployment workflow about capistrano-magento2 HOT 3 CLOSED

@erikhansen I'm not sure how soon I could implement and have the time to test this. If you were able to put together a PR, I would love to see this brought in!

Since it'd be adding a dependency, you'd want to make sure capistrano-pending is listed in capistrano-magento2.gemspec similar to how terminal-notifier is, and also run bundler to update the Gemfile.lock so that could be committed as well (that one is mostly for dev purposes).

Would you see this check coming before or after the deploy prompt I've got implemented (just asking for yes/no confirmation before it runs for an env named either 'prod' or 'production')?

from capistrano-magento2.

@davidalger

Would you see this check coming before or after the deploy prompt I've got implemented (just asking for yes/no confirmation before it runs for an env named either 'prod' or 'production')?

I am planning on setting up the deploy:pending output to run before the production deploy prompt. My thought process around this is that showing the user the pending change log before asking them whether they want to deploy will allow them to determine whether the branch they're deploying has the appropriate changes in it. The only downside to this is that the deploy:pending command can sometimes take 10-15 seconds to output any content, so the user might switch away from Terminal without realizing that the deploy won't continue unless they explicitly confirm that they want to deploy to production.

Even when I haven't had a deploy:pending check in place, there have been several times where I've forgotten about a production deploy prompt and have switched back to Terminal minutes later, only to find out that my cap prod deploy command was not running as I failed to confirm that I wanted to deploy to production.

One thought about how to avoid the issue with users missing the production deploy prompt would be to trigger an OS X notification like "Are you sure you want to deploy to <STAGE>". terminal-notifier supports removing notifications (see the -remove flag), so that notification could be removed once the user entered "y" or "N".

Would you accept two separate PRs that:

1. Adds the deploy:pending check before the production deploy prompt
2. Displays a "Are you sure you want to deploy to <STAGE>" notification that would be dismissed when the user answered the prompt

from capistrano-magento2.

Available in 0.4.0. Closing. See PR for details.

from capistrano-magento2.