Giter VIP home page Giter VIP logo

Comments (11)

davidegiacometti avatar davidegiacometti commented on June 19, 2024

Hi @Berserker2251

Which version of Edge are you using?
... (3 dots menu) > Help and feedback > About Microsoft Edge

Can you also attach here the PowerToys Run log? %LOCALAPPDATA%\Microsoft\PowerToys\PowerToys Run\Logs\0.76.2.0\2024-01-07.txt. Ensure to change your PowerToys version in the path if different than 0.76.2.0.

from powertoys-run-edgefavorite.

Berserker2251 avatar Berserker2251 commented on June 19, 2024

Edge Version 120.0.2210.121 (Official build) (64-bit)

FYI, Powertoys just updated from 0.76.2.0 to 0.77.0
2024-01-07.txt

from powertoys-run-edgefavorite.

davidegiacometti avatar davidegiacometti commented on June 19, 2024

There are some errors related to the file used by Edge to store favorites.

[2024-01-07 20:32:05.3217] [WARN] [D:\a\PowerToys-Run-EdgeFavorite\PowerToys-Run-EdgeFavorite\Community.PowerToys.Run.Plugin.EdgeFavorite\Helpers\FavoriteProvider.cs::40]
Failed to find bookmarks file C:\Users\lddha\AppData\Local\Microsoft\Edge\User Data\Default\Bookmarks
System.UnauthorizedAccessException: Access to the path 'C:\Users\lddha\AppData\Local\Microsoft\Edge\User Data\Default\Bookmarks' is denied.
   Source: System.Private.CoreLib
   TargetAssembly: System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e
   TargetModule: System.Private.CoreLib.dll
   TargetSite: Microsoft.Win32.SafeHandles.SafeFileHandle CreateFile(System.String, System.IO.FileMode, System.IO.FileAccess, System.IO.FileShare, System.IO.FileOptions)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.CreateFile(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   at System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access)
   at Community.PowerToys.Run.Plugin.EdgeFavorite.Helpers.FavoriteProvider.InitFavorites()
   at Community.PowerToys.Run.Plugin.EdgeFavorite.Helpers.FavoriteProvider.<.ctor>b__5_0(Object s, FileSystemEventArgs e)
   at System.IO.FileSystemWatcher.NotifyFileSystemEventArgs(WatcherChangeTypes changeType, ReadOnlySpan`1 name)
   at System.IO.FileSystemWatcher.ParseEventBufferAndNotifyForEach(ReadOnlySpan`1 buffer)
   at System.IO.FileSystemWatcher.ReadDirectoryChangesCallback(UInt32 errorCode, UInt32 numBytes, AsyncReadState state)
   at System.IO.FileSystemWatcher.<>c.<StartRaisingEvents>b__85_0(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* overlappedPointer)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.PortableThreadPool.IOCompletionPoller.Callback.Invoke(Event e)
   at System.Threading.ThreadPoolTypedWorkItemQueue`2.System.Threading.IThreadPoolWorkItem.Execute()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()

Can you check if you have the following files and its permissions? Are you able to open it with notepad?
C:\Users\lddha\AppData\Local\Microsoft\Edge\User Data\Default\Bookmarks

from powertoys-run-edgefavorite.

Berserker2251 avatar Berserker2251 commented on June 19, 2024

It seems that the folder is existing but no file is within the folder. If I delete the folder and restart would it work properly?

from powertoys-run-edgefavorite.

davidegiacometti avatar davidegiacometti commented on June 19, 2024

Wondering something happened to the Edge profile during edge reset but I can't give you assistance for this.

Can you type edge://version/ in Edge address bar and paste here the value of the Profile path property?
For me is set to the file where the plugins read the bookmarks file: C:\Users\david\AppData\Local\Microsoft\Edge\User Data\Default. I guess you may have a different folder.

from powertoys-run-edgefavorite.

Berserker2251 avatar Berserker2251 commented on June 19, 2024

Yeah, it seems mine is not 'Default'. It has changed to 'Profile 1'

Profile path : C:\Users\lddha\AppData\Local\Microsoft\Edge\User Data\Profile 1

Just renaming the access folder to this path would do the job wouldn't it?

from powertoys-run-edgefavorite.

davidegiacometti avatar davidegiacometti commented on June 19, 2024

I don't think so and unfortunately I can't provide assistance to change the profile.

The plugin is currently supporting only the default profile.
Implementing #6 would definitely help.

from powertoys-run-edgefavorite.

Berserker2251 avatar Berserker2251 commented on June 19, 2024

No problem, thank you of your assistance anyway. 🙂

This is something I would hope to see would come to Powertoys as this is the most beneficial addon for Powertoys Run.
Until that, will be waiting till the multiple profiles support update happens.

from powertoys-run-edgefavorite.

davidegiacometti avatar davidegiacometti commented on June 19, 2024

Hi @Berserker2251

I have just released a pre-release of the plugin that introduce the support for multiple Edge profiles and it should also fix your case: https://github.com/davidegiacometti/PowerToys-Run-EdgeFavorite/releases/tag/0.3.0

Any feedback would be appreciated.

from powertoys-run-edgefavorite.

Berserker2251 avatar Berserker2251 commented on June 19, 2024

Yes, it worked. Thank you for fixing my issue.

This one is just a suggestion,
if you could add support to previewing thumbnails of the bookmarks it would be nice

I'll keep you posted if any other issue comes up.

from powertoys-run-edgefavorite.

davidegiacometti avatar davidegiacometti commented on June 19, 2024

@Berserker2251 I am glad that it's working! 🚀

I have already looked into thumbnails, but prefer not to implement them for now.
If I change my ideas, I will include them in a future upgrade. Thanks for your understanding! 😊

from powertoys-run-edgefavorite.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.