setState() called after dispose(): about flutter_built_redux HOT 4 CLOSED

May be a call to cancel the subscription _storeSub?.cancel(); is needed before subscription since it can be call multiple times before dispose.

from flutter_built_redux.

Hey, thanks for lettin me know. I'm AFK for the holidays but I can look into this as soon as I get back. I think you're probably right though, it is probably creating additional subscriptions if didChangeDependencies is called multiple times in the lifecycle of a given widget. Rather _storeSub?.cancel(); I think it might make more sense to just wrap the body of didChangeDependencies in a if (_storeSub == null) so if the widget is already subscribed it will not set up an additional subscription.

I'll have to play around with it and maybe read a bit more into didChangeDependencies to make sure that is the best place to setup subscriptions.

from flutter_built_redux.

I was able to reproduce the problem using the redux_built app from flutter_architecture_samples. When navigating from Todos tab to Stats and back, the backtrace occurs. I tried the fix proposed by @davidmarne and it works.

from flutter_built_redux.

fix in #12

from flutter_built_redux.