Giter VIP home page Giter VIP logo

Comments (6)

davidmyersdev avatar davidmyersdev commented on May 23, 2024 1

Ah, that makes sense. I think fs runs into the same problem with fs/promises not playing well with packages like memfs that do not specify subpath exports. I'll see if I can get something working for subpath patterns. 👍

from vite-plugin-node-polyfills.

davidmyersdev avatar davidmyersdev commented on May 23, 2024

This relates to #16. I think the best approach here is to use the new overrides feature to specify a better polyfill for path that meets your specific use case.

from vite-plugin-node-polyfills.

j4k0xb avatar j4k0xb commented on May 23, 2024

path-browserify already defaults to the posix implementation and my lib gets bundled for both node (without a polyfill) and web (path-browserify), so I can't change the import to just "path" as that would be different on windows pcs.

But the main issue is that there's no way to make vite-plugin-node-polyfills resolve the whole path/posix... instead it concatenates "node_modules/<path polyfill>" + "/posix" and basically no polyfill has this file structure or subpath pattern.

would it be possible to allow overrides like { 'path/posix': 'foo' } or is there a better way?

from vite-plugin-node-polyfills.

davidmyersdev avatar davidmyersdev commented on May 23, 2024

I've started looking into this, and I found a temporary workaround. Add a custom alias to your Vite config that points to the corresponding polyfill:

import { defineConfig } from 'vite'
import { nodePolyfills } from 'vite-plugin-node-polyfills'

// https://vitejs.dev/config/
export default defineConfig({
  plugins: [
    nodePolyfills(),
  ],
  resolve: {
    alias: {
      'path/posix': 'path-browserify',
    },
  },
})

from vite-plugin-node-polyfills.

j4k0xb avatar j4k0xb commented on May 23, 2024

That seems to work for the small project I sent earlier but doesn't work for my local one.
After a lot of testing I finally found out that it only happens when https://github.com/solidjs/vite-plugin-solid is active, specifically this line: https://github.com/solidjs/vite-plugin-solid/blob/2b37a130f9f2cbece9e27bbdce6b67f16424866f/src/index.ts#L310
So there's a difference between the resolve.alias being an object and an array with find/replace
Repro: https://stackblitz.com/edit/vitejs-vite-z8v1wp?file=vite.config.js,main.js

I also found another workaround:

import { posix } from 'path';
const { dirname, join, relative } = posix;

from vite-plugin-node-polyfills.

mkilpatrick avatar mkilpatrick commented on May 23, 2024

Bump on this.

from vite-plugin-node-polyfills.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.