Support Vite 5 about vite-plugin-node-polyfills HOT 8 CLOSED

Hi, I'm new to the npm ecosystem, but wouldn't it be more accurate to write :

  "overrides": {
    "vite-plugin-node-polyfills": {
      "vite": "^5.0.1"
    }
  }

@bdbvb

from vite-plugin-node-polyfills.

@TomPlum it seems that is was only on your environment. Installation, building and also the tests are working/passing on my side. I just opened #57 that adds vite v5 to the peer dependencies

from vite-plugin-node-polyfills.

Thanks @maxnowack - I'll have a look at sorting my local 👍🏻

from vite-plugin-node-polyfills.

Hey @davidmyersdev, can you review this and get this merge? I really need the polyfills since I am migrating from Webpack to Vite 5.

from vite-plugin-node-polyfills.

@maxnowack when do you think you can get this merge? I really need this package for Vite 5

from vite-plugin-node-polyfills.

Hey @daiky00, I mentioned this issue from another repository. The PR on SignalDB doesn't fix this issue, but is also just waiting for a fix, since it's blocking the PR from which I mentioned it. It's just a reference.

Fixing this issue should be done by the maintainer of vite-plugin-node-polyfills @davidmyersdev

from vite-plugin-node-polyfills.

I was gonna raise a PR but I'm getting issues with PNPM when setting up locally. Unsure if its an issue with my local environment. Bumping vite causes a couple of other deps to need to be bumped too. One of them also has the same peer-dependency issue downstream. Build and tests are failing after that though so probably needs someone more experienced with this stuff to have a look.

The override works for now if I bump other vite plugins.

from vite-plugin-node-polyfills.

This was released in v0.17.0.

from vite-plugin-node-polyfills.