xwinfo missing on Arch (AppImage and AUR) about protonup-qt HOT 3 CLOSED

The dependency check for STL is separate from the check ProtonUp-Qt performs, you can see the code for it here: https://github.com/DavidoTek/ProtonUp-Qt/blob/main/pupgui2/resources/ctmods/ctmod_steamtinkerlaunch.py#L164-L204

I think for the xwininfo check, we can perform host_which('xwininfo') or host_which('xwinfo').

However, STL itself does expect xwininfo. If running xwininfo doesn't work, then STL will not work. The SteamTinkerLaunch AUR package also lists xorg-xwininfo as the dependency, not xwinfo. So it may be best to link or add an alias for xwinfo.

It seems like xwinfo is an AUR package and not a standard Arch Linux package either, at least yay is only showing it as an AUR package.

I don't think this is bug per-se but given that STL expects specific names for its internal dependencies, it may not be a good idea for ProtonUp-Qt to go against this.

The internal program names STL expects are as follows:

GIT="git"
PGREP="pgrep"
PIDOF="pidof"
PKILL="pkill"
TAR="tar"
UNZIP="unzip"
WGET="wget"
XDO="xdotool"
XPROP="xprop"
XRANDR="xrandr"
XWININFO="xwininfo"
XXD="xxd"

ProtonUp-Qt matches these names too, we made sure of this when writing the SteamTinkerLaunch ctmod. So if there is a strong case to made for allowing xwinfo it would have to be done on the SteamTinkerLaunch side first.

from protonup-qt.

@sonic2kk Thanks! In that case, can you update the dependencies screen to show xwininfo instead of xwinfo?

from protonup-qt.

No problem, I got a PR up for it at #301 :-)

If in doubt as well, always double-check the SteamTinkerLaunch dependencies section on the installation guide. ProtonUp-Qt only enforces the hard dependencies so STL can function, but there are several optional dependencies as well. I don't see any further discrepancies between ProtonUp-Qt's list and SteamTinkerLaunch's. The ctmod description also makes note of this:

SteamTinkerLaunch has a number of Optional Dependencies which have to be installed separately for extra functionality. Please see the Optional Dependencies section of the SteamTinkerLaunch Installation guide on its GitHub page.

And this is a little off-trackk, but just to echo something I say on the STL repo as well, make sure you're using SteamTinkerLaunch-git. There is currently no change in hard dependencies between old and git :-)

from protonup-qt.