Comments (6)
The disadvantage I see with this is that things can be become expensive to compute quite fast. You are rendering everything, not just what the user is seeing. In addition, if you change some ratoms associated with hidden tabs, everything will be re-rendered. 😢
If you want animations, wouldn't it be better to use React lifecycle handles like :component-will-unmount
?
from re-com.
@Frozenlock, I think you bring up a great point.
Depending on how the hallowed reagent/atom
is structured, any change in one tab may or maynot trigger (invisible) updates for another tab. I tend to structure my app-state
as:
{...
:tab-1 {...}
:tab-2 {...}
...}
So the effects in one tab don't have any effects on another tab as data is compartmentalised.
This has the advantage that the swtiching tabs is really smooth as from a DOM perspective only a very few things are changing.
Ofcourse either way there will be a big browser repaint.
So I think with the current strategy and the proposed strategy, there are suboptimal solutions.
But, if adding and removing the classes is moved down to an individual tab component using :component-will-unmount
and :component-did-mount
, it may be possible be achieve the same effect without re-com deciding how how many tabs are laid out. It may be possible to achieve either.
I am going to modify my code to see how it functions.
from re-com.
I've improved the code so that now you can choose to show all the tabs or not. The code is now in tab-all
branch.
The example has been updated as well. You may need to clear your browser cache to display the latest version.
In the example, the text above the line is based on all tabs being present. Below the line, the component changes on tab change.
With this new change, the code is a lot simpler and smaller. Nothing will be changed in re-com
rather a Tab
component will be added.
from re-com.
Update: I've learnt enough css to realise that this is possible to do this in pure css without changing anything in this library.
from re-com.
Good to hear you've solved this (re-com repo has not been receiving much love of late due to commercial realities taking precedence). Indeed CSS is a dark art, capable of many things that most are blissfully unaware of, including, no doubt, me.
from re-com.
no worries @Gregg8. But I am a big fan of the work you guys have done here along with re-frame.
from re-com.
Related Issues (20)
- Allow v-table :model to render re-frame subscriptions as well as reagent atoms? HOT 5
- Validate r/atom vs cljs.core/atom for :modal Arguments
- problem with simple-v-table?
- simple-v-table: Unknown parameter: :striped? HOT 1
- Base font size
- Bootstrap out of date HOT 2
- Tour component demo breaks on clicking "Start Tour!" button HOT 1
- Filter issue when using hiccup for labels in multi-select
- Check-box styling is overridden by browser instead of bootstrap HOT 2
- disabled list should not show on hover background HOT 2
- Conflicting documentation in splits HOT 1
- Datepicker header height increases when a disabled next or previous year button is displayed HOT 1
- Missing icons? HOT 1
- Pass event to popover :on-cancel
- status icon :error has incorrect zmdi-spinner in class
- v-table scrollbar thumb colors are hardcoded (potential PR)
- reagent 1.2.0 reagent.dom/dom-node is deprecated HOT 1
- Bizarre issue with the typeahead component HOT 1
- enhancement: Support :enabled? prop on tab components HOT 1
- horizontal-bar-tabs: Suppress redundant on-click handler calls HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from re-com.