Ellisons don't play nice with column alignment about lsp HOT 5 CLOSED

yeah, i see this too.

from lsp.

This is a major issue that really affects user experience. I will need to address it first, thanks for bringing it up.

from lsp.

If you can point me to the section to stare at I'd be happy to give a fix a go.

from lsp.

Wow, that would have been amazing, thanks @BAXTER001 ! The func in question is in fmt.go@PrintColumns(filename, description string).

There is this complication that I use colorstring library that converts colour tags within the string into escape characters to show coloured text in shell:

   fmt.Println(colorstring.Color("[blue]Hello [red]World!"))

These colour tags skew off the string lengths. Not sure how to bypass that easily at this stage. Maybe use other shell coloring library with a different syntax?

Maybe add a new ShellString type:

        type struct ShellString {
            s string
            color string
        }

        func (s ShellString) String() string {
            return colorstring.Color("["+s.color+"]"+  s.s) 
       }

        func (s ShellString) Length() string {
            return strings.RuneCountInString(s.s) 
       }

I think that would be the most idiomatic go way (see e.g. NullString in database/sql package) but that is quite a lot of refactoring.

from lsp.

While we are at it, we can also make it support general number of columns, not just two. Something like PrintColumns(columns []string) instead of PrintColumns(filename, description string).

Should have done this right at the time. But nooo 😜

from lsp.