Giter VIP home page Giter VIP logo

Comments (9)

ciejer avatar ciejer commented on May 8, 2024 3

I've got the same issue here - pre-commit is receiving a single parameter "run --files <space-separated file list>" rather than separate parameters.
We used the steps straight off the readme, and while the workaround above worked for us this is suboptimal for new users.
Any ideas what's causing this?

from dbt-checkpoint.

seamus-mckinsey avatar seamus-mckinsey commented on May 8, 2024 1

FWIW, I ended up not using the GHA and just installed precommit in the workflow so I could call the hooks I specifically wanted, which works for me:

    steps:
      - name: Checkout branch
        uses: actions/checkout@v2
      - name: Setup python
        uses: actions/setup-python@v4
        with:
          python-version: '3.9'
      - name: Install pre-commit
        run: pip install pre-commit
      - name: Get changed files
        id: get_file_changes
        uses: trilom/[email protected]
        with:
          output: ' '
      - name: run pre-commit-dbt added files
        if: steps.get_file_changes.outputs.files_added != '' && always()
        shell: bash
        run: |
          pre-commit run check-script-has-no-table-name --files ${{ steps.get_file_changes.outputs.files_added }} |

from dbt-checkpoint.

tomsej avatar tomsej commented on May 8, 2024

Thank you @miki-lwy I will take a look

from dbt-checkpoint.

natarajanc-prodigygame avatar natarajanc-prodigygame commented on May 8, 2024

i faced the same issue

from dbt-checkpoint.

simon-tarr avatar simon-tarr commented on May 8, 2024

I'm also getting this issue, running the latest commit (cc144b9). Is there a workaround to this error for the time being?

from dbt-checkpoint.

natarajanc-prodigygame avatar natarajanc-prodigygame commented on May 8, 2024

hi @tomsej any chance you had a chance to take a look at this ? thanks for making this package - the github actions would really help us

from dbt-checkpoint.

ehmartens avatar ehmartens commented on May 8, 2024

This issue was also a problem for me. I'm planning to use the workaround noted here.

from dbt-checkpoint.

HarelNavina avatar HarelNavina commented on May 8, 2024

FWIW, I ended up not using the GHA and just installed precommit in the workflow so I could call the hooks I specifically wanted, which works for me:

    steps:
      - name: Checkout branch
        uses: actions/checkout@v2
      - name: Setup python
        uses: actions/setup-python@v4
        with:
          python-version: '3.9'
      - name: Install pre-commit
        run: pip install pre-commit
      - name: Get changed files
        id: get_file_changes
        uses: trilom/[email protected]
        with:
          output: ' '
      - name: run pre-commit-dbt added files
        if: steps.get_file_changes.outputs.files_added != '' && always()
        shell: bash
        run: |
          pre-commit run check-script-has-no-table-name --files ${{ steps.get_file_changes.outputs.files_added }} |

Is there a way to use this workaround and still pass the env_vars to my profiles.yml file?

from dbt-checkpoint.

alexfetterman avatar alexfetterman commented on May 8, 2024

Running into the same issue. Wondering if we will se an update here at any point soon?

from dbt-checkpoint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.