Giter VIP home page Giter VIP logo

Comments (6)

dlubawy avatar dlubawy commented on June 11, 2024 1

Looks like I missed that this was also found in ADAP-1016.

from dbt-bigquery.

colin-rogers-dbt avatar colin-rogers-dbt commented on June 11, 2024 1

Thanks for raising this @dlubawy, it's worth noting that the fix we have pushed out likely does not address this specific case as setting a static batch_id will be expected to fail on rerun (that's how dataproc batch Id's are supposed to work). Ultimately where we should go is probably having the config allow you to specify a batch_id prefix and we add the invocation_id as a suffix so that each run has a distinct batch_id.

from dbt-bigquery.

dlubawy avatar dlubawy commented on June 11, 2024

This was found after trying to bypass the ADAP-1067 issue by setting a custom batch_id.

from dbt-bigquery.

dlubawy avatar dlubawy commented on June 11, 2024

Thanks for raising this @dlubawy, it's worth noting that the fix we have pushed out likely does not address this specific case as setting a static batch_id will be expected to fail on rerun (that's how dataproc batch Id's are supposed to work). Ultimately where we should go is probably having the config allow you to specify a batch_id prefix and we add the invocation_id as a suffix so that each run has a distinct batch_id.

Prefix with an appended invocation_id sounds like a good idea. However, there would need to be some enforcement on the user input for the configuration such that this wouldn't break due to batch_id length constraints. This is the issue for #1050 when batch_id was being derived from node names in v1.7.

from dbt-bigquery.

nathaniel-may avatar nathaniel-may commented on June 11, 2024

This issue implies we have some opportunities to improve the UX around batch id.

from dbt-bigquery.

tanghyd avatar tanghyd commented on June 11, 2024

I've been running into this problem for a while now. For completeness on issue tracking, I'll link my recent comment on a related issue: #1006.

from dbt-bigquery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.