Comments (2)
@QMalcolm looking at this now, I'm wondering if we (I) missed is_partition
in the RFC 🤔 . From the documentation & code, this doesn't look to be doing anything that we wouldn't want it to do in the new implementation.
I would propose that we amend the discussion to include is_partition and include it in the new spec. That would mean that the only property that would need to be removed would be Metadata
as it will be implemented in dbt-core with meta
.
from dbt-semantic-interfaces.
The only other one that I think would need to change would be removing time_format
from DimensionTypeParams. It appears that it was primarily used for legacy support (as inferred by comment?). The only places it is used in the codebase is in the dimension class and then in tests.
class DimensionTypeParams(HashableBaseModel):
"""Dimension type params add additional context to some types (time) of dimensions"""
is_primary: bool = False
# For legacy support. This is not used.
time_format: str = ISO8601_FMT
time_granularity: TimeGranularity
validity_params: Optional[DimensionValidityParams] = None
from dbt-semantic-interfaces.
Related Issues (20)
- [Bug] Please support pydantic-2.x HOT 2
- [SL-1489] [Bug] The pydantic shim isn't being included in the `wheel` distributions of the package
- [SL-1491] [CI/CD] Create github action that checks the produced distributions are functional
- [SL-1507] Release 0.5.0a3
- [SL-1508] Release 0.4.3 HOT 1
- [SL-1563] [Feature] Add `meta` to Metric/SemanticModel HOT 2
- [Feature] Add cache config to saved query HOT 3
- [Feature] Add `timezone` key to time dimensions `type_params` HOT 1
- [SL-1603] Remove `create_metric` from protocol spec
- [SL-1610] [SL-1610] [Bug] Referencing entities in where filter causes an error.
- [Python 3.12] Support + test against python 3.12 in dbt-semantic-interfaces
- [Feature] Allow specifying saved query group by items with dundered syntax vs the object syntax HOT 1
- [Bug] Derived metric validation allows empty input metric set
- [Bug] Make `expr` required for derived metrics
- [Feature] Support referencing a metric in where filter HOT 1
- [Feature] Sub-daily granularity
- [Feature] Relax double underscore requirement on metrics HOT 4
- [Feature] Add `period_agg` field for cumulative metrics
- [Feature] Add `default_grain` to metric spec HOT 1
- [Bug] Inconsistency between time dimension Jinja objects for `time_granularity_name`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dbt-semantic-interfaces.