Giter VIP home page Giter VIP logo

Comments (2)

callum-mcdata avatar callum-mcdata commented on July 21, 2024

@QMalcolm looking at this now, I'm wondering if we (I) missed is_partition in the RFC 🤔 . From the documentation & code, this doesn't look to be doing anything that we wouldn't want it to do in the new implementation.

I would propose that we amend the discussion to include is_partition and include it in the new spec. That would mean that the only property that would need to be removed would be Metadata as it will be implemented in dbt-core with meta.

from dbt-semantic-interfaces.

callum-mcdata avatar callum-mcdata commented on July 21, 2024

The only other one that I think would need to change would be removing time_format from DimensionTypeParams. It appears that it was primarily used for legacy support (as inferred by comment?). The only places it is used in the codebase is in the dimension class and then in tests.

class DimensionTypeParams(HashableBaseModel):
    """Dimension type params add additional context to some types (time) of dimensions"""

    is_primary: bool = False
    # For legacy support. This is not used.
    time_format: str = ISO8601_FMT
    time_granularity: TimeGranularity
    validity_params: Optional[DimensionValidityParams] = None

from dbt-semantic-interfaces.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.