Date Time / Daylight Saving Time about qtxlsxwriter HOT 3 CLOSED

Hi, Thanks for your feedback. As QDateTime::isDaylightTime() is introduced in Qt5.2, so we can add this these two lines

#if QT_VERSION >= 0x050200
    if (dt.isDaylightTime())    // Add one hour if the date is Daylight
        excel_time += 1.0 / 24.0;
#endif

At the same time, datetimeFromNumber() should be updated too.

from qtxlsxwriter.

Hi, I push a new commit for this. Can you give a try to it?

from qtxlsxwriter.

Hi,

the changes you made look fine to me.
I'm just not sure if the check in function datetimeFromNumber(double num, bool is1904)

dt2.isDaylightTime()

should be made after subtracting an hour (as You did) or before.

thanks
riki

from qtxlsxwriter.