Comments (12)
@strugee: I want to emphasize again that my comment(s) above was unprofessional and unnecessary. I appreciate that you are trying to improve this package. Keep up your enthusiasm for open source software!
from bcrypt.js.
its a good idea to include a change log...!! (y)
from bcrypt.js.
But, for which recent changes? This package is mostly in maintenance mode and the commit history is quite overseeable nowadays.
from bcrypt.js.
@dcodeIO the package is at major version 2. I'd like to know what changed between those versions. I'd also like a broad overview of how the project has progressed over time, but that's less important than the semver-major changes.
As for the commit history, I like what http://keepachangelog.com says:
Why canβt people just use a
git log
diff?Because log diffs are full of noise β by nature. They could not make a suitable change log even in a hypothetical project run by perfect humans who never make typos, never forget to commit new files, never miss any part of a refactoring. The purpose of a commit is to document one atomic step in the process by which the code evolves from one state to another. The purpose of a change log is to document the noteworthy differences between these states.
As is the difference between good comments and the code itself, so is the difference between a change log and the commit log: one describes the why, the other the how.
from bcrypt.js.
I like what http://www.urbandictionary.com/define.php?term=smarty%20pants says
from bcrypt.js.
@dcodeIO uh... I'm sorry? I don't know how you found my comment rude but I was just trying to answer your question. That's all.
from bcrypt.js.
I find it a bit ironic that this reply chain lands in my inbox the same week GitHub's open source survey results come out identifying rudeness and name calling being the most common negative reactions encountered by contributors.
As an outsider looking in, let's be civil shall we? @dcodeIO I appreciate your project. If there are no breaking changes between v1 and v2, should be simple to call that out in the readme.
from bcrypt.js.
I actually intended to be a bit rude there, as it is a bit rude feels annoying to be educated that a git commit history isn't a change log - twice. No worries, though, it's all happening in a controlled environment and I know that you / he didn't mean to offend anyone. Sorry for that!
Back to topic: I certainly understand that every project should have a change log. I was just wondering about the timing because nothing really happens here. I'll add one with the next change, if necessary, or you can go ahead and contribute one.
from bcrypt.js.
@dcodeIO I really don't know how to respond to that. How in the world is educating someone else rude? I for one really like learning new things and having my perspectives challenged. I've been programming for five years and would consider myself a relatively "seasoned" programmer, but I still have a huge amount to learn. I just honestly can't understand your position.
Was it because I said it twice? I said it twice because you explicitly asked about the commit history, so I pulled a quote from a resource I'd already linked to. The question was already answered. Was I supposed to just not answer your question?
Maybe there's a cultural difference here?
In any case, I don't think I personally have the bandwidth to go through and write up a change log. But it'd be awesome if someone else did.
from bcrypt.js.
Sorry, "rude" wasn't the correct term there. I meant "annoying".
from bcrypt.js.
@dcodeIO thanks for saying that! I feel for you - I've had bad days as a maintainer too.
So no hard feelings :)
from bcrypt.js.
I think this issue/suggestion should be closed? I don' think there will come a change log as it has a very low priority.
from bcrypt.js.
Related Issues (20)
- Trailing underscores are not accounted for. HOT 1
- Bcryptjs on browser is not functioning properly. HOT 3
- hopefully can delete email address or write them on the README.md
- Can't resolve 'crypto', BREAKING CHANGE: webpack <5 used to include polyfills? HOT 3
- Bcryptjs compares badly with jwt and its hash HOT 5
- Error: Illegal arguments: undefined, string HOT 1
- issues with compare/compareSync via docker compose env
- This repository is no longer maintained HOT 3
- How bcryptjs works?
- This library is maintained
- Bcrypt compare always return false HOT 3
- bcryptjs.compare returns illegal arguments error
- Error: Illegal arguments: string, undefined HOT 1
- How to decript password?????? HOT 5
- genSalt not working on nodejs esm
- Unclear license status HOT 2
- Vite: Module "crypto" has been externalized for browser compatibility
- Cannot Import from `bcryptjs` in a Playwright Test HOT 1
- Crypto With Nextjs X.X HOT 1
- Inquiry about the Current Status of the Library
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bcrypt.js.