define_hash_object based hashes derive PartialEq but implement Hash about cardano-multiplatform-lib HOT 2 CLOSED

This shouldn't be an issue here. The Hash trait is working on the direct bytes, just as the Ord/etc is, so the invariant specified in that link (k1 == k2 ⇒ hash(k1) == hash(k2)) to avoid issues (I imagine hashmap keys) still holds. I'm not sure exactly why it was originally written (this is pulled from old Jormungandr code right?) they didn't use the default Hash derivation, but it was probably to do with how without const generics (still unstable I think?, and definitely wasn't a thing back then) you couldn't auto-derive traits using const generics (e.g. N for number constants in [T; N]) so they had to manually specify a bunch of traits on [T, 1], [T, 2]... [T, 32] and anything above lacks most or all traits. Maybe Ord and such were so core to the language they had a special exception and Hash didn't.

@SebastienGllmt should we keep this open or just close it? Or if it's a problem for clippy we could put an ignore in the code, although after the refactor I guess.

from cardano-multiplatform-lib.

Fixed by #250

from cardano-multiplatform-lib.