Giter VIP home page Giter VIP logo

Comments (5)

0xfaulty avatar 0xfaulty commented on June 2, 2024 1

Testing with different release versions, the first version where this happens is 16.8, so it's probably related to this change

[Client] Merge entity textures to reduce memory usage [Jupeyy] (#6275)

Could we have MAP_IMAGE_MOD_TYPE_HIDE or smth like that where server could disable client entities (current behaviour)? Bcs I use that bug to prevent clients to see some map details in some areas :)

from ddnet.

Robyt3 avatar Robyt3 commented on June 2, 2024 1

Could we have MAP_IMAGE_MOD_TYPE_HIDE or smth like that where server could disable client entities (current behaviour)? Bcs I use that bug to prevent clients to see some map details in some areas :)

Needs a discussion and is separate from this bug, so I opened a separate issue #7970 for this.

from ddnet.

Jupeyy avatar Jupeyy commented on June 2, 2024

Also note: the code for the server was not changed in ~2 years.

So something in the client changed to cause this I assume

from ddnet.

Robyt3 avatar Robyt3 commented on June 2, 2024

Seems to happen for any server that wants the client to use anything except the DDNet entities. You can reproduce this on any server by forcing the choice of entities in the client by setting EntitiesModType manually in the following:

ddnet/src/game/client/components/mapimages.cpp

Lines 186 to 204 in 8870eb9

IGraphics::CTextureHandle CMapImages::GetEntities(EMapImageEntityLayerType EntityLayerType)
{
EMapImageModType EntitiesModType = MAP_IMAGE_MOD_TYPE_DDNET;
bool EntitiesAreMasked = !GameClient()->m_GameInfo.m_DontMaskEntities;
if(GameClient()->m_GameInfo.m_EntitiesFDDrace)
EntitiesModType = MAP_IMAGE_MOD_TYPE_FDDRACE;
else if(GameClient()->m_GameInfo.m_EntitiesDDNet)
EntitiesModType = MAP_IMAGE_MOD_TYPE_DDNET;
else if(GameClient()->m_GameInfo.m_EntitiesDDRace)
EntitiesModType = MAP_IMAGE_MOD_TYPE_DDRACE;
else if(GameClient()->m_GameInfo.m_EntitiesRace)
EntitiesModType = MAP_IMAGE_MOD_TYPE_RACE;
else if(GameClient()->m_GameInfo.m_EntitiesBW)
EntitiesModType = MAP_IMAGE_MOD_TYPE_BLOCKWORLDS;
else if(GameClient()->m_GameInfo.m_EntitiesFNG)
EntitiesModType = MAP_IMAGE_MOD_TYPE_FNG;
else if(GameClient()->m_GameInfo.m_EntitiesVanilla)
EntitiesModType = MAP_IMAGE_MOD_TYPE_VANILLA;

from ddnet.

Robyt3 avatar Robyt3 commented on June 2, 2024

Testing with different release versions, the first version where this happens is 16.8, so it's probably related to this change

[Client] Merge entity textures to reduce memory usage [Jupeyy] (#6275)

from ddnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.