Bug: Pagy::Backend#pagy_get_vars `count_args` gets ignored about pagy HOT 3 CLOSED

Hi @lasha-meister,
Not sure about how you get that...

0> Book.all.count
D, [2024-03-19T19:45:51.028977 #6880] DEBUG -- :   Book Count (0.1ms)  SELECT COUNT(*) FROM "books"
=> 11

0> Book.all.count(:id)
D, [2024-03-19T19:45:56.231342 #6880] DEBUG -- :   Book Count (0.2ms)  SELECT COUNT("books"."id") FROM "books"
=> 11

0> p, r = pagy(Book.all)
D, [2024-03-19T19:46:07.115069 #6880] DEBUG -- :   Book Count (0.1ms)  SELECT COUNT(*) FROM "books"
D, [2024-03-19T19:46:07.140286 #6880] DEBUG -- :   Book Load (0.4ms)  SELECT "books".* FROM "books" /* loading for inspect */ LIMIT ? OFFSET ?  [["LIMIT", 11], ["OFFSET", 0]]
=> Error: the evaluation of `to_s` with the arguments `[]` failed with the exception 'SQLite3::SQLException: no such table: books'

0> p, r = pagy(Book.all, count_args: :id)
D, [2024-03-19T19:46:53.505508 #6880] DEBUG -- :   Book Count (0.1ms)  SELECT COUNT("books"."id") FROM "books"
D, [2024-03-19T19:46:53.510209 #6880] DEBUG -- :   Book Load (0.5ms)  SELECT "books".* FROM "books" /* loading for inspect */ LIMIT ? OFFSET ?  [["LIMIT", 11], ["OFFSET", 0]]
=> Error: the evaluation of `to_s` with the arguments `[]` failed with the exception 'SQLite3::SQLException: no such table: books'

from pagy.

Hi @lasha-meister, Not sure about how you get that...

0> Book.all.count
D, [2024-03-19T19:45:51.028977 #6880] DEBUG -- :   Book Count (0.1ms)  SELECT COUNT(*) FROM "books"
=> 11

0> Book.all.count(:id)
D, [2024-03-19T19:45:56.231342 #6880] DEBUG -- :   Book Count (0.2ms)  SELECT COUNT("books"."id") FROM "books"
=> 11

0> p, r = pagy(Book.all)
D, [2024-03-19T19:46:07.115069 #6880] DEBUG -- :   Book Count (0.1ms)  SELECT COUNT(*) FROM "books"
D, [2024-03-19T19:46:07.140286 #6880] DEBUG -- :   Book Load (0.4ms)  SELECT "books".* FROM "books" /* loading for inspect */ LIMIT ? OFFSET ?  [["LIMIT", 11], ["OFFSET", 0]]
=> Error: the evaluation of `to_s` with the arguments `[]` failed with the exception 'SQLite3::SQLException: no such table: books'

0> p, r = pagy(Book.all, count_args: :id)
D, [2024-03-19T19:46:53.505508 #6880] DEBUG -- :   Book Count (0.1ms)  SELECT COUNT("books"."id") FROM "books"
D, [2024-03-19T19:46:53.510209 #6880] DEBUG -- :   Book Load (0.5ms)  SELECT "books".* FROM "books" /* loading for inspect */ LIMIT ? OFFSET ?  [["LIMIT", 11], ["OFFSET", 0]]
=> Error: the evaluation of `to_s` with the arguments `[]` failed with the exception 'SQLite3::SQLException: no such table: books'

That's the thing, with the console I also get correct behavior, but when I do this:

@pagy, @collection = pagy(@ranksack_collection, count_args: :id)

I get this in rack mini profiler, only after my monkey-patch do I get count on the id column :)

from pagy.

I cannot help without any provided code support.

I already ignored that fundamental prerequisite and answered to your issue, which only wasted both of our times, because we got exactly zero progress in understanding it.

You guessed a "solution" for your special case, which may be OK for your case, but it's worth nothing in the context of pagy, because we cannot even say whether it's a pagy issue, an AR issue, a DB issue, an issue of some other library used by your code or an issue of your own code.

By just guessing I would say that it's not a pagy issue at all, because either the way we pass the arguments to count is wrong in pagy (i.e. a design problem), OR it's not a problem with pagy since you get the same error without pagy. If it's wrong in pagy, then please point me to some doc that explains why and we will change pagy or its doc.

If you think it's pagy that is causing the problem, please provide some basic code (and please extract the very minimum from your app). Consider that I must be able to run it with a single command and reproduce it without steps to follow, configuration to prepare and especially no guessing.

Thank you for understanding.

from pagy.