Giter VIP home page Giter VIP logo

Comments (9)

MysticalOS avatar MysticalOS commented on June 18, 2024

update dungeon mod, this is fixed in in latest update already.

from dbm-dungeons.

gotex007 avatar gotex007 commented on June 18, 2024

I just ran this on my ret pally and Strife specifically wasn't calling to swap but Peril was working properly.

Edit: I ran another one today and it worked properly so I'm not sure what happened before.

from dbm-dungeons.

MysticalOS avatar MysticalOS commented on June 18, 2024

Works on both, based on target. if you weren't targeting it when it reached 7 stacks you got no alert. I've done this boss plenty to know it's working

from dbm-dungeons.

gotex007 avatar gotex007 commented on June 18, 2024

I definitely was targeting him. Just wanted to report the occurrence. Happened all 3 times he hit 7 stacks.

Edit: I ran another one today and it worked properly so I'm not sure what happened before.

from dbm-dungeons.

gotex007 avatar gotex007 commented on June 18, 2024

Works on both, based on target. if you weren't targeting it when it reached 7 stacks you got no alert. I've done this boss plenty to know it's working

It happened again today. I verified with my friends in the key that it was happening to them too. It would only call it for Peril and would not call it (not even once out of three times) on Strife. I have no idea what triggers it to do that. I mean it's not that big of a deal I guess and the season is ending soon anyway.

from dbm-dungeons.

MysticalOS avatar MysticalOS commented on June 18, 2024

i've done it myself, and watched it on stream, I've never seen it fail. and code wise, I see no reason for it to fail either unless for some reason the name is missing from combat log do to a missing translation. I guess I can hard code a fallback for missing name in combat log.

But the events are correct.
https://www.warcraftlogs.com/reports/H32cTrWYAvyjxQV4#fight=last&pins=2%24Off%24%23244F4B%24expression%24ability.id%20%3D%20113315&view=events&translate=true

they both use same one. if it works for one, it works for both

from dbm-dungeons.

gotex007 avatar gotex007 commented on June 18, 2024

Should I upload the log if it happens again? Would that help try to identify what triggers it? It's probably not worth worrying about at this point of the season but I just wanted to report that it had happened again and I verified with others that it happened at the time.

from dbm-dungeons.

MysticalOS avatar MysticalOS commented on June 18, 2024

nope. this issue will not be looked into at all cause it works fine for me and nothing wrong with code that logs would fix. either you have another mod breaking it, or you're encountering some obscure blizzard bug I couldn't work around anyways. I've checked every possible combat log, code path, plus fact i've done dungeon dozens of times this season with no bugs. I just can't fix what isn't broken.

from dbm-dungeons.

gotex007 avatar gotex007 commented on June 18, 2024

You linked a log file which is why I asked. Like I said I don't really think it's worth caring about since it's the season is coming to an end. I just wanted to report it happening and that it wasn't just me it happened to. It doesn't even happen consistently. I'm sorry that this caused you such annoyance.

from dbm-dungeons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.