Issue with the Dock icons in Ubuntu 22.04+ about jazz2-native HOT 3 CLOSED

Hi! Thanks, I will change it, but I wonder if StartupWMClass can be just anything or it has to be @NCINE_PREFERRED_BACKEND@-Application.

I'm using Discord for all discussions, but it's ok to discuss it here too.

I'm building it with following command on GitHub Actions: cmake -D CMAKE_BUILD_TYPE=Release -D NCINE_STRIP_BINARIES=ON -D NCINE_PREFERRED_BACKEND=$backend -D NCINE_ASSEMBLE_DEB=ON -D NCINE_ASSEMBLE_RPM=ON -D NCINE_WITH_GLEW=OFF

NCINE_ASSEMBLE_DEB generates DEB package automatically. NCINE_ASSEMBLE_RPM generates RPM package which probably you don't need. NCINE_PREFERRED_BACKEND can be GLFW or SDL2 (QT5 is not supported). It seems SDL2 has better gamepad support. On the other hand, GLFW is more lightweight. But I haven't done any deep comparison, both work very similar for me. I turned NCINE_LINKTIME_OPTIMIZATION on by default recently, so you don't need to specify it, but other options you mentioned are right. NCINE_STRIP_BINARIES can be used to strip debug information for smaller binaries.

And yes, system dependencies have higher priority than Libs, so you don't need to pre-download them separately. Also, I added Ogg Vorbis dependency recently, but I don't know name of the package.

I'm not sure about the copyright. As all code was written by me (except dependencies), it would be better this one:

Copyright: Copyright (C) 2016-2023 Dan R.

Thanks for including it in the repository and let me know if you have some other issues/questions.

from jazz2-native.

The StartupWMClass needs to match the correct startup class, otherwise it doesn't work. I used "xprop WM_CLASS" to figure it out. I'm assuming the SDL startup class will match the same way. I did not test it.

I saw your pipelines. I inspired myself on them. :-)
NCINE_STRIP_BINARIES - The Debian packaging system will strip and build the dbgsym .deb automatically from it. So, this cannot be set if I want to make the debug symbols available to install.
NCINE_ASSEMBLE_DEB - I must use the Debian packaging method. Not needed.

Concerning Ogg Vorbis we have two packages: libogg-dev and libvorbis-dev... The build did not complain about any of them. Not sure which one to include.

Copyright updated.

Thank you!

from jazz2-native.

Fixed in the latest commits as we discussed.

from jazz2-native.