Giter VIP home page Giter VIP logo

Comments (19)

deckameron avatar deckameron commented on July 17, 2024 1

@ottopic,
I have never considered merging with appcelerator modules, but I will as soon as I finish what you asked. :)

from ti.android.admob.

deckameron avatar deckameron commented on July 17, 2024 1

@ottopic I see.
I must have made a mistake on my code. I will investigate asap.

from ti.android.admob.

deckameron avatar deckameron commented on July 17, 2024 1

Hi @ottopic,
I am sorry! I could not fix it last week. I was in a middle of the end of the world putting out fires!
I will be available again on next weekend and I promise you I will implement it correctly.

from ti.android.admob.

deckameron avatar deckameron commented on July 17, 2024 1

Thank you @Astrovic !

from ti.android.admob.

deckameron avatar deckameron commented on July 17, 2024

Hi @ottopic
Yes! I plan to do it, but not right now. I am loaded with stuff at work and don't have the time.
Maybe in a few weeks.

from ti.android.admob.

ottopic avatar ottopic commented on July 17, 2024

Thank you for your reply @deckameron !
Have you ever consider to merge into ti.admob project contributing with yours Android interstitial implementation?

Best regards.

from ti.android.admob.

deckameron avatar deckameron commented on July 17, 2024

@ottopic Could you test version 3.0.4, please?

Just follow appcelerator admob module docs for now. I will update the my docs some other time.

from ti.android.admob.

ottopic avatar ottopic commented on July 17, 2024

Thank you @deckameron , I'll try ASAP.

from ti.android.admob.

ottopic avatar ottopic commented on July 17, 2024

@deckameron I tried 3.0.4 to request GDPR consent but get in error.
If I understood what you wrote I have to use ti.admob configuration to request consent.

Uncaught TypeError: Admob.requestConsentInfoUpdateForPublisherIdentifiers is not a function

function requestConsentInfo(call) {
    Admob.requestConsentInfoUpdateForPublisherIdentifiers({
        publisherIdentifiers: ['pub-xxxxxxxxxxxxxxxxx'],
        callback: function (e) {
            log.info(JSON.stringify(e));
            if(e.success && call != '') eval(call + '()');
        }
    });
}

from ti.android.admob.

ottopic avatar ottopic commented on July 17, 2024

Hi @deckameron , have you tried to find mistake? Can I help you ?

from ti.android.admob.

deckameron avatar deckameron commented on July 17, 2024

Hi @ottopic,
Could you test 3.0.5, please?

from ti.android.admob.

ottopic avatar ottopic commented on July 17, 2024

Thank you @deckameron .
It's seems there is a syntax error:

[ERROR] : SyntaxError: Missing catch or finally after try

from ti.android.admob.

deckameron avatar deckameron commented on July 17, 2024

@ottopic I see!
What method was it? requestConsentInfoUpdateForPublisherIdentifiers?

from ti.android.admob.

ottopic avatar ottopic commented on July 17, 2024

Problem should be simulator and liveview, I'll test on device asap.

from ti.android.admob.

ottopic avatar ottopic commented on July 17, 2024

Running on device there isn't syntax error, but I don't see popup, I get error [ERROR] : AndroidProtocolHandler: Unable to open asset URL: file:///android_asset/consentform.html .

Do you have example?

from ti.android.admob.

Astrovic avatar Astrovic commented on July 17, 2024

To personally manage the GDPR form, it would be useful to add a Bundle extras to all types of ads, as specified in the documentation https://developers.google.com/admob/android/eu-consent#forward_consent_to_the_google_mobile_ads_sdk, to be able to pass for example extras: {'npa':'1'} to disable personalized ads. As was done in ti.admob module (https://github.com/appcelerator-modules/ti.admob/blob/63426867b1ed957135a29405a4d8b7097b81770a/android/src/ti/admob/View.java#L71)

from ti.android.admob.

deckameron avatar deckameron commented on July 17, 2024

Hi @Astrovic
Thank you! I will implement asap.

from ti.android.admob.

deckameron avatar deckameron commented on July 17, 2024

Hi @Astrovic
Could you try this version, please?

from ti.android.admob.

Astrovic avatar Astrovic commented on July 17, 2024

Hi @deckameron it seems to work properly, well done!!

from ti.android.admob.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.