Reflections not longer maintained, needs to be removed or replaced about deegree3 HOT 3 CLOSED

relates to #1401

from deegree3.

The @Tool annotation is used in the following CLIs documented in #1386

from deegree3.

The org.reflections:reflections from OGCFrontController is related to the extraction of maven build information.

• deegree3/deegree-core/deegree-core-workspace/src/main/java/org/deegree/workspace/standard/ModuleInfo.java

  Lines 133 to 163 in 4a715f7

  	ConfigurationBuilder builder = new ConfigurationBuilder();
  	builder = builder.setUrls(classpathURL);
  	builder = builder.setScanners(new ResourcesScanner());
  	Reflections r = new Reflections(builder);
  	Set<String> resources = r.getResources(Pattern.compile("(MANIFEST\\.MF)"));
  	if (!resources.isEmpty()) {
  	URLClassLoader classLoader = new URLClassLoader(new URL[] { classpathURL }, null);
  	String resourcePath = resources.iterator().next();
  	InputStream buildInfoStream = null;
  	try {
  	Properties props = new Properties();
  	buildInfoStream = classLoader.getResourceAsStream(resourcePath);
  	props.load(buildInfoStream);
  	String buildArtifactId = props.getProperty("deegree-build-artifactId",
  	props.getProperty("build.artifactId"));
  	if (buildArtifactId == null) {
  	// skipping because this jar is not from deegree
  	return null;
  	}
  	String buildBy = props.getProperty("deegree-build-by", props.getProperty("build.by"));
  	String buildDate = props.getProperty("deegree-build-date", props.getProperty("build.date"));
  	String buildRev = props.getProperty("deegree-build-rev", props.getProperty("build.svnrev"));
  	String version = retrieveVersion(props, r, classLoader, buildArtifactId, classpathURL);
  	return new ModuleInfo(buildArtifactId, version, buildRev, buildDate, buildBy);
  	}
  	finally {
  	closeQuietly(buildInfoStream);
  	}
  	}
  	return null;

In general, I would suggest removing the dependency on org.reflections:reflections.
The question remains whether we want to continue to retrieve build information from the deegree modules (jar) or not.

If we decide to keep these build information, an alternative could be to use java ServiceLoader:

• Add a centralized Helper class using ServiceLoader to load all known subclasses
• Define an abstract class containing the loading capabilities that require a class/class loader reference
• Inject a dummy class in each module/jar implementing the abstract class which provides a local class/class loader reference
• Define a service in each module/jar to this implementation (META-INF/services/xxxx)

from deegree3.