Giter VIP home page Giter VIP logo

Comments (10)

Ganonmaster avatar Ganonmaster commented on April 28, 2024 2

Merged #13 and #14 which takes care of the conversion script.

from faceswap.

deepfakes avatar deepfakes commented on April 28, 2024

Also if you have ideas for a better folder structure, feel free to suggest!

from faceswap.

Ganonmaster avatar Ganonmaster commented on April 28, 2024

I would propose to keep the different "actions" or steps in their current files (train.py, convert.py, extract.py) and then allow for model data directory names to be used as input/output arguments. Example:

train.py --data-dirs="./data/trump;/data/cage" --model-dir="./models/trump-cage/"

from faceswap.

deepfakes avatar deepfakes commented on April 28, 2024

seems fine to me

from faceswap.

Ganonmaster avatar Ganonmaster commented on April 28, 2024

extract.py now has basic command line options for specifying paths and verbose output. I'm going to be looking at convert.py next.

from faceswap.

Ganonmaster avatar Ganonmaster commented on April 28, 2024

Updated train.py and accidentally pushed results to upstream. I'm very drunk, so if someone could verify if the scripts are still working, please do so.

Now that all these scripts are using the same basic classes, we can probably consolidate them to a single file so they can be called from a single entrypoint. (like how git has several subcommands, faceswap.py could have extract, train and convert commands) That's my next objective, which I will be looking to tackle tomorrow. (after the hangover passes)

from faceswap.

Clorr avatar Clorr commented on April 28, 2024

I pushed also accidentally yesterday and I was not even drunk...

No problem, have a look tomorrow. Me I'll be on the way back to my family...

from faceswap.

Yutsa avatar Yutsa commented on April 28, 2024

If we could manage to create a program with different commands it would be way easier to use indeed.

Something like faceswap extract, faceswap train and faceswap convert

from faceswap.

Ganonmaster avatar Ganonmaster commented on April 28, 2024

Thank you, @Yutsa for implementing this functionality.

from faceswap.

Ganonmaster avatar Ganonmaster commented on April 28, 2024

This issue should probably be closed and split up into more specific issues since we have some basic command line usage now.

from faceswap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.