Unexported fields not working anymore since v2.2.0 about oapi-codegen HOT 5 OPEN

Thanks for the report - what's the use-case for having models that produce unexported fields?

Not saying that we won't fix it, but it's a a surprising use-case, so would be interested to hear why you're doing this @lukasbash

from oapi-codegen.

With the proposed code (from v2.1.0's behaviour), we end up receiving a go vet violation:

% go vet
# github.com/deepmap/oapi-codegen/v2/examples/extensions/x
./gen.go:14:2: struct field accountIdentifier has json tag but is not exported

from oapi-codegen.

@jamietanna We are using some unexported fields of models during internal processing which offers dynamic implementations on the server side. Sometimes we are using those fields for performance optimizations whereas the clients do not need those fields e.g. when the model is part of a JSON response.

Ironically - with regard to your latest reply - for those unexported fields we usually comply with omitting field tags like:

# ...
            x-oapi-codegen-extra-tags:
              json: "-"
              gorm: "-"
              foo: "-"
              bar: "-"
# ...

What implementation/usage do you suggest? Throwing an error on generation when an unexported field contains a tag? Or do you state that generated files might not be fully lint-compliant and people have to exclude those from linting?

EDIT: The vet violation was not present in v2.1.0? Strange, because I would guess that the tag implementation didn't change for this, did it?

from oapi-codegen.

The vet violation was not present in v2.1.0?

In the v2.1.0 code we didn't have any cases in the codebase which would rely on producing unexported fields, which is why we wouldn't have seen any violations. I can imagine that if we did, we would've fixed the violation.

It's not something I'd like to recommend is done by default, but I think it'd be OK to add it in as an opt-in feature - would that work for you?

If so, I'd be happy if you want to contribute it? Although we've not yet got a "howto" doc on doing this, af43038 is a recent example that should give a good indication of how to add it in?

from oapi-codegen.