Giter VIP home page Giter VIP logo

Comments (14)

travisp avatar travisp commented on May 31, 2024

More specifically, the above threads work on pry-byebug commit 5c72fb5, but not 2 commits later b0eba72 (I can't test the commit in the middle because I get exceptions). It appears to be that it's simply of a matter of whether Byebug.start has been called or not (in the earlier version, Byebug.start was not called initially). Even on the earlier version, once the user has entered a command such as next, any threads hang.

from pry-byebug.

deivid-rodriguez avatar deivid-rodriguez commented on May 31, 2024

Could you try to reproduce this using latest pry-byebug and byebug (from master). I think it should be fixed in byebug.

from pry-byebug.

travisp avatar travisp commented on May 31, 2024

@deivid-rodriguez Unfortunately it seems that in pry-byebug master 917c365 and byebug master 99bd3269deb790 the problem still remains.

from pry-byebug.

deivid-rodriguez avatar deivid-rodriguez commented on May 31, 2024

You means the problem remains separately in byebug´s master or using pry-byebug (master) + byebug (master).

from pry-byebug.

olivierlacan avatar olivierlacan commented on May 31, 2024

@deivid-rodriguez Running both byebug master and pry-byebug master I'm still seeing hangs inside of capybara-webkit threads as well. Is there anything that could help you with this issue?

Basic setup I have is rspec with Capybara and capybara-webkit.
In spec_helper.rb:

Capybara.javascript_driver = :webkit

RSpec.configure do |config|
#...
  config.around(:each, js: true) do |example|
    Capybara.using_driver(:webkit, &example)
  end
end

In the spec itself:

require 'spec_helper'

describe 'Something', js: true do
  it 'does something' do
    before do
      binding.pry
    end
  end
end

Running the spec, when the Pry session starts, any call to find('#selector') hangs indefinitely.

from pry-byebug.

deivid-rodriguez avatar deivid-rodriguez commented on May 31, 2024

Are you able to reproduce using byebug master only?

from pry-byebug.

olivierlacan avatar olivierlacan commented on May 31, 2024

@deivid-rodriguez Yep. That's what I did originally. I had the last release of pry-byebug I think and byebug master.

from pry-byebug.

deivid-rodriguez avatar deivid-rodriguez commented on May 31, 2024

@olivierlacan Did you uninstall pry-byebug, installed byebug's master branch and then reproduced this using byebug instead of binding.pry?

If that's the case, open an issue in byebug's repo?

from pry-byebug.

travisp avatar travisp commented on May 31, 2024

@deivid-rodriguez I tested again with the latest (after 091cff) in byebug. With byebug alone the problem does not seem to exist. With pry-byebug the problem remains for me and thoughtbot/capybara-webkit#718 seems to still be an issue for me too.

from pry-byebug.

deivid-rodriguez avatar deivid-rodriguez commented on May 31, 2024

@travisp I guess this is because pry-byebug is not using latest byebug's master. This should be fixed in next release.

@olivierlacan Sorry if my last sentence sounded rude, it's missing "could you".. :)

from pry-byebug.

deivid-rodriguez avatar deivid-rodriguez commented on May 31, 2024

Closing for lack of feedback. Feel free to reopen if still happening.

from pry-byebug.

travisp avatar travisp commented on May 31, 2024

@deivid-rodriguez on pry-byebug 3.1.0 and byebug 4.0, as well as pry-byebug master this still remains an issue -- any threads run in this context seem to hang.

from pry-byebug.

justin808 avatar justin808 commented on May 31, 2024

I just tried this and also ran into this issue. So still seems like an issue.

from pry-byebug.

deivid-rodriguez avatar deivid-rodriguez commented on May 31, 2024

This seems like a duplicate of #69. Let's comment there.

from pry-byebug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.