Giter VIP home page Giter VIP logo

Comments (3)

ocram avatar ocram commented on May 18, 2024

Thanks for your appreciation!

Everything you said was correct and this is definitely a missing feature that we must add. I'd even say this should have the highest priority, since undelivered emails can be quite frequent depending on how you sent your emails, and inattentive users will cause problems, anyway.

Regarding the implementation, I wouldn't make that method public but instead create a simple wrapper. This gives us two advantages: The new wrapper can have a meaningful name like resendConfirmation and we can do some additional database queries in the wrapper. First, we could check that the last request has been a while ago, i.e. you shouldn't be able to request a new confirmation just ten minutes after the first one. Second, as you said, we should invalidate the old request.

Thanks for the hint, this is absolutely needed!

from php-auth.

steinitzu avatar steinitzu commented on May 18, 2024

That sounds great!
Rate limiting would definitely be needed too, should be configurable in some way. Maybe just by passing a min number of seconds that should have passed to resendConfirmation.

from php-auth.

ocram avatar ocram commented on May 18, 2024

Implemented in:

This is available in a new major version, v6.0.0, which comes with a few breaking changes. For a guide on how to upgrade, please see the migration notes in Migration.md.

from php-auth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.