Giter VIP home page Giter VIP logo

Comments (8)

colinjfw avatar colinjfw commented on July 17, 2024 1

Thanks again for reporting @italolelis - I'm trying to repro on a branch https://github.com/deliverybot/helm/tree/issue-repro so I'll see if I get it.

Can see I tried to repro here: https://github.com/deliverybot/helm/runs/232949600

In the mean time, if you set the secret ACTIONS_STEP_DEBUG=true it should give you much more debugging output to view what's going on.

from helm.

colinjfw avatar colinjfw commented on July 17, 2024

@italolelis my guess is that I was misunderstanding how GitHub resolves deliverybot/helm@v1. I thought that this would resolve to the latest v1.0.0 but I don't think that's the case.

This should now be fixed - I pushed a branch https://github.com/deliverybot/helm/tree/v1 which will be kept up to date with the v1 series. I think the following refs should also be valid if you want to use them:

Thanks for filing this issue!! Let me know if the problem is resolved.

from helm.

italolelis avatar italolelis commented on July 17, 2024

Hey @colinjfw,

Thanks for the answer. I also thought it would resolve to 1.0.0.
So, I tried with master and the full tag ref but bumped into this error:

Current runner version: '2.158.0'
Prepare workflow directory
Prepare all required actions
Download action repository 'actions/checkout@v1'
Download action repository 'deliverybot/helm@master'
##[error]'gcr.io/deliverybot/helm:v1.0.0' should be either '[path]/Dockerfile' or 'docker://image[:tag]'.

I didn't really understand what could be wrong as I can see that you have the Dockerfile in the root folder as required. Maybe this has to be declared somewhere?

from helm.

colinjfw avatar colinjfw commented on July 17, 2024

Ya I think something may have changed a bit since I used actions last, I pushed this commit adf2971 which I hoped would solve this problem.

I tried myself with the following targets deliverybot/helm@master and deliverybot/helm@mv1 and it seemed to work. I think that the tag v1.0.0 doesn't have the docker:// syntax that actions now requires.

from helm.

colinjfw avatar colinjfw commented on July 17, 2024

I reverted to just using image: Dockerfile in the action.yml in this commit here: 7eddfb9

This seems to be the way to do it given the GitHub documentation. It would be nice to eventually have it pull from gcr but it seems like maybe that's a future thing for actions and isn't documented at the moment.

from helm.

italolelis avatar italolelis commented on July 17, 2024

Thanks a lot for the changes @colinjfw . I was able to pull the master version now.
I am still facing an issue thought, in which the error message is not clear. I'm not sure where to look for the problem.

/usr/bin/docker run --name bb818a5a850b9a87413bbd97642f295d25f8_60b812 --label 04bb81 --workdir /github/workspace --rm -e KUBECONFIG_FILE -e INPUT_CHART -e INPUT_TRACK -e INPUT_VERSION -e INPUT_TOKEN -e INPUT_SECRETS -e INPUT_VALUE_FILES -e INPUT_RELEASE -e INPUT_NAMESPACE -e INPUT_VALUES -e INPUT_DRY-RUN -e INPUT_VALUE-FILES -e HOME -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/my-chart/my-chart":"/github/workspace" 04bb81:8a5a850b9a87413bbd97642f295d25f8
##[error]Error: ENOENT: no such file or directory, open ''
##[error]ENOENT: no such file or directory, open ''
##[error]Docker run failed with exit code 1

And this is my configuration. I looked at how you configured the action in the testing script and I could notice 2 different things: You use helm3 and I don't and you are pointing to the built in chart and I'm pointing to one on my repository. Maybe one of these 2 things are producing the empty path that cannot be found?

    - name: Deploy
      uses: deliverybot/helm@master
      with:
        chart: ./charts/my-chart
        track: stable
        version: ${{ github.sha }}
        token: ${{ github.token }}
        secrets: ${{ toJSON(secrets) }}
        value_files: '["./charts/my-chart/values.yaml", "./charts/my-chart/values-staging.yaml"]'
        release: my-chart
        namespace: default
        values: |
          tag: ${{ github.sha }}
      env:
        KUBECONFIG_FILE: ${{ secrets.STAGING_KUBECONFIG }}

I tried with multple combinations, usign my charts or the built in, and it always produce the same error.

I appreciate your help once again.

from helm.

italolelis avatar italolelis commented on July 17, 2024

Thanks a lot @colinjfw, that helped me to find what was wrong.
It was the value_files that need to be with a dash value-files πŸ€¦β€β™‚

I was able to deploy properly. Now the big expectation is for when Github replies to #6 πŸ˜„

Thank you again. I will close this issue.

from helm.

colinjfw avatar colinjfw commented on July 17, 2024

from helm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.