Comments (4)
lucacasonato
commented on May 7, 2024
2
Yeah, I am aware of this issue. It is relatively difficult to deal with.
from fresh.
lucacasonato
commented on May 7, 2024
1
With the new "island" based architecture, this is not a problem anymore.
from fresh.
kuboon
commented on May 7, 2024
I tried adding build option define: {IS_BROWSER: true} to here
https://github.com/lucacasonato/fresh/blob/044da545134b91142e215dc349ec37a59e52cd25/src/server/bundle.ts#L41
but nothing happened. Maybe I have some misunderstanding..
from fresh.
sylc
commented on May 7, 2024
This could also easily trip people passing credentials to db calls in a useData fetcher, which is probably one of the main use case of useData, as the credentials will end up in the client bundle.
In the mean time of a proper fix, maybe adding a note in the useData readme to signal that credentials should be passed by environment variables with deno.env.get() could help some.
I'm happy to raise a PR if that helps.
from fresh.
Related Issues (20)
- Add a way for plug-ins to know whether the app is run from dev.ts HOT 5
- The road to Fresh 2.0 HOT 26
- Location and description of import_map.json
- docs: explain better the distinction between islands and components HOT 5
- Can't see unminified Preact source code in Chrome debugger
- Fresh updater fails when deno.jsonc is in parent folder HOT 1
- Support React as alternative to Preact HOT 5
- CSP nonce issue?
- dangerouslySetInnerHTML usage in <head> breaks style plugins HOT 6
- Is the way you collect statistics GDPR-compliant? HOT 3
- Hooks stop working when importing npm modules HOT 5
- Docs: code in snippet is wrong
- Conditional Island Children HOT 2
- Easy way to augment esbuild configuration HOT 4
- @tabler/icons-preact error on islands component and dev mode HOT 1
- [bug] deno compile binary does not work on other machines HOT 1
- Hook is already inside component, yet error `Hook can only be invoked from render methods` still occurs HOT 1
- Client Address Bar wont update after 303 redirect response. HOT 4
- JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists. || pragmaFrag cannot be set when runtime is automatic HOT 2
- [Bug] Preact's hydrate will clear uncontrolled property(e.g.`defaultValue) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fresh.