Giter VIP home page Giter VIP logo

Comments (8)

zchee avatar zchee commented on June 1, 2024

@tweekmonster I was poor physical condition yesterday.
I'll reply later :)

from deoplete-jedi.

zchee avatar zchee commented on June 1, 2024

@tweekmonster I understand.
and, I mistook deoplete.nvim implementation.

I want to use converter_auto_paren.
https://github.com/Shougo/deoplete.nvim/blob/master/rplugin%2Fpython3%2Fdeoplete%2Ffilters%2Fconverter_auto_paren.py

I use the following to assist with completions:

FYI, I use neopairs.vim
https://github.com/Shougo/neopairs.vim

So, I think good behavior is

  1. If users wants automatically completion bracket, set
    call deoplete#custom#set('_', 'converters', ['converter_auto_paren'])
  2. deoplete-jedi add ( in abbr or info (maybe already implemented)
  3. converter_auto_paren add ( in word
  4. If users use neopairs.vim, automatically completion )

and, remove ( and . completion in deoplete-jedi.

WDYT?

from deoplete-jedi.

tweekmonster avatar tweekmonster commented on June 1, 2024

@zchee I'll have to try neopairs to understand fully, but it sounds good so far.

It looks like abbr or info needs to have () in it for the converter. This will leave a problem with Python properties.

In case you don't know:

class Example(object):
    @property
    def example_property(self):
        return True

e = Example()
print(e.ex

When you do a completion on the last line, Jedi will report that example_property is a function, which is correct. But, it would mean deoplete-jedi will add () to it for abbr. This needs to be addressed before using converter_auto_paren is recommended.

I think it's possible to distinguish properties from functions and improve some other ambiguous descriptions. I'm going to try and submit a PR if I'm successful.

For now I think it's best to simply remove ( and . from completion.

from deoplete-jedi.

zchee avatar zchee commented on June 1, 2024

@tweekmonster Hm, That is correct.
Certainly, this example result is print(e.example_property(). last char's () is not necessary.

I'm going to try and submit a PR if I'm successful.

OK, I look forward to your pull request :) Thanks.

from deoplete-jedi.

zchee avatar zchee commented on June 1, 2024

@tweekmonster

For now I think it's best to simply remove ( and . from completion.

OK, I will remove ( and . completion later.

from deoplete-jedi.

zchee avatar zchee commented on June 1, 2024

@tweekmonster

Off topic:
FYI, Shougo/echodoc.vim also good deoplete.nvim support plugin.
Try use it :)

from deoplete-jedi.

tweekmonster avatar tweekmonster commented on June 1, 2024

FYI, Shougo/echodoc.vim also good deoplete.nvim support plugin.

Holy shit that's a good plugin now that I tried it. I needed this a long time ago. Thanks! I thought it was for showing the full documentation of a completion when I read the docs for deoplete.nvim. echodoc.nvim doesn't really describe itself either.

from deoplete-jedi.

zchee avatar zchee commented on June 1, 2024

@tweekmonster 😁 🎉

from deoplete-jedi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.