Comments (5)
XhmikosR
commented on June 3, 2024
1
@GiladShoham yeah you are probably right. Unsure how to make tests pass again on Node.js 20. If you have any suggestions feel free to make a PR and CC me.
EDIT: I just looked at your linked PRs. It seems it's just a matter of calling toString('utf-8'). Anyway, feel free to make a PR.
from node-dependency-tree.
GiladShoham
commented on June 3, 2024
I have the same problem.
@XhmikosR which version of node it started?
Seems like it works with 20.4.0 but fail on 20.5.0
from node-dependency-tree.
GiladShoham
commented on June 3, 2024
Maybe it's related to this change in 20.5.0
[986b46a567] - fs: add a fast-path for readFileSync utf-8 (Yagiz Nizipli) nodejs/node#48658
from node-dependency-tree.
GiladShoham
commented on June 3, 2024
another relevant reference is here - kubernetes-client/javascript#1202
and also this one - tschaub/mock-fs#377
from node-dependency-tree.
XhmikosR
commented on June 3, 2024
I pushed a branch with debug enabled on CI and the issue seems to be with fs.existsSync:
- Node.js 18: https://github.com/dependents/node-dependency-tree/actions/runs/8565544868/job/23473747457
- Node.js 20: https://github.com/dependents/node-dependency-tree/actions/runs/8565544868/job/23473747584
Unsure how to proceed...
We are also hitting this in other repos like node-stylus-lookup:
- https://github.com/dependents/node-stylus-lookup/actions/runs/8565474632/job/23473580973
- https://github.com/dependents/node-stylus-lookup/actions/runs/8565474632/job/23473581057
EDIT: looks like it's a mock-fs issue? tschaub/mock-fs#377
from node-dependency-tree.
Related Issues (20)
- npm i --global-style
- dynamic import with Typescript doesn't work. HOT 10
- Exclude unused import HOT 3
- Sass imports from node_modules HOT 1
- fix(tsconfig): path mapping (module alias)
- Out of memory without `--list-form` HOT 1
- Find dependents
- Why not supporting an object for webpackConfig parameter? HOT 1
- Don't support alias in webpack.config.js
- Node package.json exports field not understood.
- feat: list import identifiers in dep tree HOT 3
- Why is precinctOptions.includeCore always false?
- dependencyTree only returning an empty object HOT 2
- Help fix
- Miss typings definine in package.json `files` HOT 1
- Resolving local/nested node_modules folder
- Hello author
- Filter out type import dependencies HOT 2
- How I can easily change the code to get the url of images in the tree ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-dependency-tree.