Comments (2)
jamesmyatt
commented on May 26, 2024
The first thing that pd.concat does is convert the input to a list (https://github.com/pandas-dev/pandas/blob/eaee348792cf45b0f8ca52944f066b7f27503066/pandas/core/reshape/concat.py#L342) so IMO there's not much value in changing this code. Also, I often need to pass some extra arguments, which means that it's a choice between writing pd.concat([df for df in my_dfs], ...) and pd.concat((df for df in my_dfs), ...), which is basically the same for readability.
But OTOH, you're a pandas dev, so I don't know why I'm telling you this. Basically, I'm saying that I agree, but this should be a low priority to add.
from pandas-vet.
MarcoGorelli
commented on May 26, 2024
Hi @jamesmyatt
thanks for your reply!
Yeah having thought about this further, it's probably similar to how ''.join is more efficient with a list comprehension (https://stackoverflow.com/a/9061024/4451315), so it's probably not worth having a rule about
from pandas-vet.
Related Issues (20)
- pandas-vet should run when flake-8 invoked by pre-commit HOT 1
- Automate releases to PyPI and conda-forge
- Challenging PD008: .at can be useful HOT 3
- False positive: dict().values()
- False positive: PD005 for regex `sub` method HOT 1
- New approach to docs with JupyterBook HOT 1
- inplace set to a variable raises exception
- PD011 - shoud be to_numpy() instead of to_array()?
- Improve contributor experience HOT 1
- Constant column check with `nunique` HOT 2
- `PD012` is outdated HOT 1
- Improve official docs
- Check for proper `reset_index`
- torch.Tensor.sort return type values access PD011 false positive
- Add nox support to run tests, flake8, black locally HOT 1
- Add banners to Readme. HOT 1
- Add check for python functions that should be pandas methods
- Add notes about disabling checks to README
- Conda and pip install (0.2.2) not showing plugins with flake8 --version; 0.2.1 works HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pandas-vet.