Giter VIP home page Giter VIP logo

Comments (3)

der-gabe avatar der-gabe commented on July 28, 2024

Looks like this is set globally per field-type in django.contrib.admin.options:

FORMFIELD_FOR_DBFIELD_DEFAULTS = {
    …
    models.CharField: {'widget': widgets.AdminTextInputWidget},
    …

(cf. source)

It's meant to be overridden via ModelAdmin.formfield_overrides - not sure much can be done at the form field level, which is where this package's code lives...

from django-colorinput.

der-gabe avatar der-gabe commented on July 28, 2024

FWIW, I got it to work by directly hacking it into that file in my local virtualenv's django installation:

from colorinput.models import ColorField
from colorinput.forms.widgets import ColorInputWidget
…
FORMFIELD_FOR_DBFIELD_DEFAULTS = {
    …
    ColorField: {'widget': ColorInputWidget},
}

… so it is possible.

Now the question becomes whether monkey-patching that dict from my reusable app code is possible, safe, robust and a good idea (or even: sane).

from django-colorinput.

der-gabe avatar der-gabe commented on July 28, 2024

I tried simply doing

import django.contrib.admin
from django.contrib.admin.options import FORMFIELD_FOR_DBFIELD_DEFAULTS

…

FORMFIELD_FOR_DBFIELD_DEFAULTS[ColorField] = {'widget': ColorInputWidget}

in colorinput/forms/fields.py and it doesn't work.

Is it because this runs at import time, or does import FORMFIELD_… provide my module's namespace with its own copy of this dict somehow, or is it a third thing (e.g some kind of race condition)?

Either way, this simple approach doesn't work and even if it did: I'm far from sure this is such a good idea. Seems like a pretty dirty hack to me.

In the worst case, I'll just have to document how to fix this through a custom ModelAdmin class with formfield_overrides so users can do that in their own projects, if it bothers them.

from django-colorinput.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.