Giter VIP home page Giter VIP logo

Comments (4)

TylorS avatar TylorS commented on June 22, 2024

I'm open to any of these additions. These are the types of things Cycle/Motorcycle are designed to handle; all pretty easy stuff.

Debouncing requests - one line of code

.debounce(100) // in milliseconds

Logging - one line of code

.do(x => console.log(x)) // or some function to format the logging

Loading/error states are as simple as a combination of adding a few .merge()s and .filter() s.
Depending on what is actually expected the LOC would vary a bit but not much would be required.

from friend-list.

TylorS avatar TylorS commented on June 22, 2024

Another thought could be animated reordering of the list

from friend-list.

DerekCuevas avatar DerekCuevas commented on June 22, 2024

Ok, awesome.

I'm going to go ahead and add debouncing, logging, and loading / error states to the spec as bonus features. Animating reordering of the list would be cool, however it seems to be an unrelated problem to the one outlined in the README. What would adding animation highlight? Would this be a good addition for the Cycle.js and Motorcycle.js solutions?

I was thinking caching could make an OK addition to the spec as well. Although this might not be very fitting, as we would probably want to keep responses as fresh as possible if this app was not just a demo. What is your opinion on this?

I'll go ahead and add some of these features to my solutions later this week (most are already implemented in the better-observable-solution, but I'll add loading and error states for completeness). If you want to add some of these features to the Motorcycle.js solution that would be great!

Thanks for your feedback!

from friend-list.

TylorS avatar TylorS commented on June 22, 2024

I'm going to go ahead and add debouncing, logging, and loading / error states to the spec as bonus features

I will look for some time to add those to my motorcycle solution.

What would adding animation highlight?

That's a good question. I don't know, I pretty much just think it'd be cool lol. It's not really too big of a deal for Motorcycle to handle, but you're probably right it doesn't really highlight anything specific to the challenge.

we would probably want to keep responses as fresh as possible if this app was not just a demo

I don't think caching would be the best addition, as I agree with your above statement.

from friend-list.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.