DatbaseLogsTable::ensureTables() causes app to crash in environments without test connection about cakephp-databaselog HOT 5 CLOSED

Can you propose a code change that would work for you?
Bear in mind that you can always set up a test connection - which you should for dev env.

And for prod it should auto use the connection defined.
maybe you forgot that:

'DatabaseLog' => [
        'datasource' => 'default',

This way it uses the default connection for sure and will not try to open an alternative one.

If you want to bypass database log for local dev, you can also do this in bootstap_cli file:

if (Configure::read('debug') || Configure::read('App.isLocal')) {
    $logTypes = array_keys(Configure::read('Log'));
    foreach ($logTypes as $logType) {
        Configure::write('Log.' . $logType . '.className', 'File');
    }
}

But you said your problem is specific to prod.

from cakephp-databaselog.

Hi Mark! Thanks for answering!

'DatabaseLog' => [
        'datasource' => 'default',

exists in my app.php.

The error itself is thrown inside CakePHP class: vendor/cakephp/cakephp/src/TestSuite/Fixture/TestFixture.php

Stack Trace:
#0 /var/www/weba_konfigurator/vendor/cakephp/cakephp/src/TestSuite/Fixture/TestFixture.php(182): Cake\Datasource\ConnectionManager::get('test')
#1 /var/www/weba_konfigurator/vendor/cakephp/cakephp/src/TestSuite/Fixture/TestFixture.php(145): Cake\TestSuite\Fixture\TestFixture->_schemaFromFields()
#2 /var/www/weba_konfigurator/vendor/dereuromark/cakephp-databaselog/tests/Fixture/DatabaseLogsFixture.php(71): Cake\TestSuite\Fixture\TestFixture->init()
#3 /var/www/weba_konfigurator/vendor/cakephp/cakephp/src/TestSuite/Fixture/TestFixture.php(113): DatabaseLog\Test\Fixture\DatabaseLogsFixture->init()
#4 /var/www/weba_konfigurator/vendor/dereuromark/cakephp-databaselog/src/Model/Table/LazyTableTrait.php(63): Cake\TestSuite\Fixture\TestFixture->__construct('default')
#5 /var/www/weba_konfigurator/vendor/dereuromark/cakephp-databaselog/src/Model/Table/DatabaseLogsTable.php(55): DatabaseLog\Model\Table\DatabaseLogsTable->ensureTables(Array)

For now I've solved the problem by creating test connection on prod. To be honest it's the first time I see testing related stuff injected into the code at the app level (and during initialization of class!). It's a bit strange for me ;)

The solution that comes to my head first is to add option in config file to omit all the test suite related stuff (and even make it default). In ma case I had to run plugin migrations manually anyway, but I didn't have time to explore why.

If I don't get something, you can close this topic. If I have some spare time I will try to make a pull request with my proposition.

from cakephp-databaselog.

Why using fixtures in prod?

from cakephp-databaselog.

Hi there! Sorry for a late reply, but honestly I forgot about that topic. I came here to report another issue, so I will reply to this one too.

Why using fixtures in prod?

I'm not using fixtures in prod, but I have them as a part of the repository, so the test-related files do exist in production environment. The error stacktrace is:

• DatabaseLogsTable calls $this->ensureTables(['DatabaseLog.DatabaseLogs']) during initialization. (line 55)
• ensureTables() creates classname using App::className($name, 'Test/Fixture', 'Fixture'); (LazyTableTrait.php, line 58) - I don't get why plugin is expecting that those classes exist, but ok, I have those fixtures
• ensureTables() tries to instantiate fixture class using $fixture = new $class($this->getConnection()->configName()); (LazyTableTrait.php, line 63)
• during initialization the framework's Cake\TestSuite\Fixture\TestFixture::init() is called, and it calls it's _schemaFromFields() method
• _schemaFromFields() gets it's own connection. which is obviously "test", because fixtures system is designed for dev only.

So once again my problem is: you are using test-related parts of the framework inside the test-unrelated plugin, which is bad solution IMO.

But don't worry - it's a small plugin, thanks for doing it. I hope I'll manage to make PR ;)

from cakephp-databaselog.

All right, looking forward to your PR.

Maybe the docs should be more clear that if you are using
https://github.com/dereuromark/CakePHP-DatabaseLog/blob/master/src/Model/Table/LazyTableTrait.php#L45 and SqLite auto build feature, that this app must not be designed for prod.
This is only meant to get started quickly for local test projects or POC apps, never for real live prod apps.

from cakephp-databaselog.