Giter VIP home page Giter VIP logo

Comments (7)

jbgi avatar jbgi commented on July 26, 2024

@DanielGronau, @clinuxrulz: I found that the constructor methods of Either and Maybe are a bit verbose, do you plan to keep them as is or would you rather drop the 'new' prefix to be more in line with other fp libraires?

I ask because the name of the methods will be hard-coded in derive4j (as well as the qualified name of Maybe, Either and F1). So it would be better if they not change just after the derive4j release.

from derive4j.

DanielGronau avatar DanielGronau commented on July 26, 2024

The constructor methods started actually as Left, Right, Just, Nothing, I changed them to to follow the Java convention of small method names (and couldn't bring myself to call them left, right etc).

However, I have no strong opinion about this, and wouldn't mind to switch back to the old uppercase names. Then there is still the question concerning the lazy counterparts. I found out that using the same name for a lazy version passing a Supplier is a bad idea.

Concerning the package structure, I'm inclined to drop the data package, and reorganize the packages inside (which look quite messy right now). I would also drop all plurals in package names. So we would end up with org.highj.collection.Either, org.highj.collection.Maybe and org.highj.function.F1

from derive4j.

jbgi avatar jbgi commented on July 26, 2024

yes, using the same name for the lazy constructor can break method reference type inference.

@DanielGronau could you drop me a note in this issue when the HighJ has settled on those points ?

from derive4j.

DanielGronau avatar DanielGronau commented on July 26, 2024

@jbgi We moved Maybe and Either to org.highj.data, and F1 to org.highj.function. Further, we changed the constructor methods to upper-case.

from derive4j.

jbgi avatar jbgi commented on July 26, 2024

@DanielGronau perfect. Need to sort out #34 and #35 and will release 0.9 shortly!

from derive4j.

jbgi avatar jbgi commented on July 26, 2024

@clinuxrulz @DanielGronau Derive4J 0.8 with the HighJ flavour should now be available on maven central!

from derive4j.

DanielGronau avatar DanielGronau commented on July 26, 2024

Thank you, I updated the dependency.

from derive4j.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.